allow to create encrypted folder directly via bottom sheet dialog by tobiasKaminsky · Pull Request #10782 · nextcloud/android

tobiasKaminsky · 2022-10-06T12:57:02Z

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Tests written, or not not needed

as per NC PR: nextcloud#10782

tobiasKaminsky · 2022-11-22T07:24:03Z

/rebase

AlvaroBrey · 2022-12-01T12:11:33Z

/rebase

codecov · 2022-12-13T16:11:12Z

Codecov Report

Merging #10782 (85e1429) into master (edec670) will decrease coverage by 0.76%.
The diff coverage is 10.20%.

❗ Current head 85e1429 differs from pull request most recent head c584fdc. Consider uploading reports for the commit c584fdc to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #10782      +/-   ##
============================================
- Coverage     31.55%   30.79%   -0.76%     
+ Complexity     3424     3275     -149     
============================================
  Files           576      564      -12     
  Lines         42134    41652     -482     
  Branches       5685     5644      -41     
============================================
- Hits          13294    12827     -467     
- Misses        26868    26894      +26     
+ Partials       1972     1931      -41

Impacted Files	Coverage Δ
...m/owncloud/android/services/OperationsService.java	`37.22% <0.00%> (+0.26%)`	⬆️
...owncloud/android/ui/adapter/OCFileListAdapter.java	`39.57% <0.00%> (-6.06%)`	⬇️
.../android/ui/dialog/CreateFolderDialogFragment.java	`0.00% <0.00%> (ø)`
...droid/ui/fragment/OCFileListBottomSheetDialog.java	`0.00% <0.00%> (ø)`
...ncloud/android/ui/fragment/OCFileListFragment.java	`35.29% <0.00%> (-4.53%)`	⬇️
...cloud/android/ui/helpers/FileOperationsHelper.java	`8.09% <0.00%> (+0.07%)`	⬆️
...loud/android/operations/CreateFolderOperation.java	`72.18% <45.45%> (-2.29%)`	⬇️
...com/nextcloud/client/database/entity/FileEntity.kt	`0.00% <0.00%> (-96.67%)`	⬇️
...owncloud/android/authentication/PassCodeManager.kt	`33.89% <0.00%> (-38.17%)`	⬇️
...com/owncloud/android/utils/theme/ViewThemeUtils.kt	`58.33% <0.00%> (-33.98%)`	⬇️
... and 88 more

AlvaroBrey

Spotbugs + below comment

app/src/main/java/com/owncloud/android/operations/CreateFolderOperation.java

github-actions · 2023-02-22T14:11:15Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10782.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

nextcloud-android-bot · 2023-02-22T14:31:56Z

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7903-IT-master-14-31

nextcloud-android-bot · 2023-02-22T14:38:26Z

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7903-IT-stable-14-37

…om NC PR: nextcloud#10782

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

…om NC PR: nextcloud#10782

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

…om NC PR: nextcloud#10782

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

github-actions · 2026-01-09T11:43:58Z

Codacy

SpotBugs

Category	Base	New
Bad practice	43	43
Correctness	74	74
Dodgy code	257	260
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	3	3
Multithreaded correctness	34	34
Performance	44	44
Security	18	18
Total	481	484

SpotBugs increased!

github-actions · 2026-01-09T11:54:28Z

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

tobiasKaminsky added the 3. to review label Oct 6, 2022

tobiasKaminsky requested a review from AlvaroBrey October 6, 2022 12:57

tobiasKaminsky added the hacktoberfest-accepted label Oct 26, 2022

tobiasKaminsky force-pushed the createEncryptedFolder branch 2 times, most recently from 799cc3a to 21be8b3 Compare November 18, 2022 14:39

tobiasKaminsky marked this pull request as ready for review November 21, 2022 07:48

tobiasKaminsky force-pushed the createEncryptedFolder branch from 21be8b3 to f8eb49d Compare November 21, 2022 07:53

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Nov 22, 2022

Allow to create encrypted folder directly via bottom sheet dialog

d2b6ea1

as per NC PR: nextcloud#10782

nextcloud-command force-pushed the createEncryptedFolder branch from f8eb49d to e36e389 Compare November 22, 2022 07:25

nextcloud-command force-pushed the createEncryptedFolder branch from e36e389 to 3a21073 Compare December 1, 2022 12:12

tobiasKaminsky force-pushed the createEncryptedFolder branch 2 times, most recently from efddccf to 85e1429 Compare December 13, 2022 13:57

AlvaroBrey requested changes Dec 13, 2022

View reviewed changes

app/src/main/java/com/owncloud/android/operations/CreateFolderOperation.java Outdated Show resolved Hide resolved

tobiasKaminsky force-pushed the createEncryptedFolder branch from 85e1429 to 0667f70 Compare February 8, 2023 10:35

tobiasKaminsky requested a review from AlvaroBrey February 8, 2023 10:35

AlvaroBrey approved these changes Feb 22, 2023

View reviewed changes

AlvaroBrey force-pushed the createEncryptedFolder branch from 0667f70 to c584fdc Compare February 22, 2023 13:58

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jun 27, 2023

Allow to create encrypted folder directly from bottom sheet dialog fr…

d43faac

…om NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jun 27, 2023

Allow to create encrypted folder directly from bottom sheet dialog fr…

4342a21

…om NC PR: nextcloud#10782

surinder-tsys mentioned this pull request Jun 27, 2023

Create e2ee folder directly from bottom sheet nextmcloud/android#107

Closed

1 task

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Aug 28, 2023

Allow to create encrypted folder directly from bottom sheet dialog fr…

7ec418c

…om NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Oct 20, 2023

Allow to create encrypted folder directly from bottom sheet dialog fr…

2cb2d34

…om NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Oct 31, 2023

Allow to create encrypted folder directly from bottom sheet dialog fr…

af08e94

…om NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Nov 2, 2023

Allow to create encrypted folder directly from bottom sheet dialog fr…

9da631a

…om NC PR: nextcloud#10782

surinder-tsys mentioned this pull request Oct 28, 2024

E2EE Customizations nextmcloud/android#71

Open

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Nov 25, 2024

NMC-1923: E2EE related changes with test cases.

d52e1a6

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jan 15, 2025

NMC-1923: E2EE related changes with test cases.

af7ec02

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jan 15, 2025

Allow to create encrypted folder directly from bottom sheet dialog fr…

2fb3105

…om NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jan 17, 2025

NMC-1923: E2EE related changes with test cases.

8636ce8

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jan 17, 2025

Allow to create encrypted folder directly from bottom sheet dialog fr…

26bb0e6

…om NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jan 28, 2025

NMC-1923: E2EE related changes with test cases.

50632cc

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jan 28, 2025

NMC-1923: E2EE related changes with test cases.

4d397e1

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

github-actions bot pushed a commit to nextmcloud/android that referenced this pull request Jan 28, 2025

NMC-1923: E2EE related changes with test cases.

e356b48

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Mar 7, 2025

NMC-1923: E2EE related changes with test cases.

9e1af13

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Mar 7, 2025

NMC-1923: E2EE related changes with test cases.

c825ae9

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Mar 10, 2025

NMC-1923: E2EE related changes with test cases.

f91a584

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Mar 10, 2025

NMC-1923: E2EE related changes with test cases.

2a4fa04

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Mar 10, 2025

NMC-1923: E2EE related changes with test cases.

186feed

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request May 12, 2025

NMC-1923: E2EE related changes with test cases.

b4f16ad

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

github-actions bot pushed a commit to nextmcloud/android that referenced this pull request Jun 17, 2025

NMC-1923: E2EE related changes with test cases.

1f6e65a

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jul 4, 2025

NMC-1923: E2EE related changes with test cases.

02335b2

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jul 4, 2025

NMC-1923: E2EE related changes with test cases.

5e848f7

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jul 4, 2025

NMC-1923: E2EE related changes with test cases.

b355572

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jul 16, 2025

NMC-1923: E2EE related changes with test cases.

78cf9fb

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jul 16, 2025

NMC-1923: E2EE related changes with test cases.

f916677

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jul 25, 2025

NMC-1923: E2EE related changes with test cases.

8d8751f

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Aug 7, 2025

NMC-1923: E2EE related changes with test cases.

b25595d

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

github-actions bot pushed a commit to nextmcloud/android that referenced this pull request Aug 26, 2025

NMC-1923: E2EE related changes with test cases.

70667a1

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Sep 11, 2025

NMC-1923: E2EE related changes with test cases.

2eed697

NMC-1550: Allow to create encrypted folder directly from bottom sheet dialog from NC PR: nextcloud#10782

tobiasKaminsky added 3 commits January 9, 2026 10:57

allow to create encrypted folder directly via bottom sheet dialog

0696234

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

rebased

7103b55

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

wip

99632b3

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

allow to create encrypted folder directly via bottom sheet dialog#10782

allow to create encrypted folder directly via bottom sheet dialog#10782
tobiasKaminsky wants to merge 3 commits intomasterfrom
createEncryptedFolder

tobiasKaminsky commented Oct 6, 2022 •

edited

Loading

Uh oh!

tobiasKaminsky commented Nov 22, 2022

Uh oh!

AlvaroBrey commented Dec 1, 2022

Uh oh!

codecov bot commented Dec 13, 2022 •

edited

Loading

Uh oh!

AlvaroBrey left a comment

Uh oh!

Uh oh!

github-actions bot commented Feb 22, 2023

Uh oh!

nextcloud-android-bot commented Feb 22, 2023

Uh oh!

nextcloud-android-bot commented Feb 22, 2023

Uh oh!

github-actions bot commented Jan 9, 2026

Uh oh!

github-actions bot commented Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

tobiasKaminsky commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tobiasKaminsky commented Nov 22, 2022

Uh oh!

AlvaroBrey commented Dec 1, 2022

Uh oh!

codecov bot commented Dec 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

AlvaroBrey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 22, 2023

Uh oh!

nextcloud-android-bot commented Feb 22, 2023

Uh oh!

nextcloud-android-bot commented Feb 22, 2023

Uh oh!

github-actions bot commented Jan 9, 2026

Codacy

SpotBugs

SpotBugs increased!

Uh oh!

github-actions bot commented Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tobiasKaminsky commented Oct 6, 2022 •

edited

Loading

codecov bot commented Dec 13, 2022 •

edited

Loading