Skip to content

Rotate images#10762

Closed
surinder-tsys wants to merge 2 commits intonextcloud:masterfrom
nextmcloud:rotate_images
Closed

Rotate images#10762
surinder-tsys wants to merge 2 commits intonextcloud:masterfrom
nextmcloud:rotate_images

Conversation

@surinder-tsys
Copy link
Collaborator

Rotate image functionality added to image files.

How it works:

  1. Open any image in preview mode.
  2. Click on 3 dot menu at top right and then click on Rotate menu option. Rotate Menu Option
  3. On clicking Rotate menu option it will rotate the image 90° clockwise.
  4. Now the rotated image will be uploaded to cloud under 2 case:
    4.1. When user rotates the screen i.e. configuration changes.
    4.2. When user comes back from the preview screen.
    Uploading rotate image notification
  5. We are updating the image thumbnail in cache to give seamless experience to user and also updating the new rotated image file with current one.

Note: Rotate functionality only applicable to JPG and PNG files.

@nextcloud-android-bot
Copy link
Collaborator

@tobiasKaminsky
Copy link
Member

Sorry for coming back this late.

I think the condition when a rotated images is saved is to unclear for the user.
I would rather use a persistent snackbar, which then directly (in background) saves the file.

2022-11-01-114010

@surinder-tsys
Copy link
Collaborator Author

@tobiasKaminsky There can be condition when user can rotate multiple images at a time and upload all the images at once.
So for this case also do we have to show Snackbar with Images has been modified or we have to handle it differently.

And just a favor is that possible to merge this branch with any of your temporary branch so that we can fix the issue reported?

@surinder-tsys
Copy link
Collaborator Author

Closing this PR as new PR has created for Rotate during new merging process and here is the link: #11490

@surinder-tsys surinder-tsys deleted the rotate_images branch July 19, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants