Skip to content

chore(records)!: Migrate data classes to records#759

Merged
AndyScherzinger merged 1 commit intomainfrom
chore/records
Oct 7, 2024
Merged

chore(records)!: Migrate data classes to records#759
AndyScherzinger merged 1 commit intomainfrom
chore/records

Conversation

@stefan-niedermann
Copy link
Member

This is a (small and easy to adapt) breaking change, but records are the structures intended to be used for pure data objects.

Note: The FilesAppTypeRegistry itself introduced in 1.3.0 was a breaking change, too.

This is a breaking change, but records are the structures intended to be used for pure data objects.

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@AndyScherzinger
Copy link
Member

Well, I'd it is fine to do and also we can simply bump to v2.0.0 to comply with semantic versioning. It is a library after all, so it is also fine to just move forward and do such changes. The number of apps making use of the lib is still relatively small and if the breaking change is easy to adapt to, that is even better then 👍

@AndyScherzinger AndyScherzinger merged commit 248e137 into main Oct 7, 2024
@AndyScherzinger AndyScherzinger deleted the chore/records branch October 7, 2024 12:17
@AndyScherzinger AndyScherzinger added this to the SSO Library 1.4.0 milestone Oct 7, 2024
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants