fix(void): Introduce new EmptyResponse type as successor for Void (#541)#542
Merged
tobiasKaminsky merged 7 commits intomasterfrom Jan 19, 2024
Merged
fix(void): Introduce new EmptyResponse type as successor for Void (#541)#542tobiasKaminsky merged 7 commits intomasterfrom
tobiasKaminsky merged 7 commits intomasterfrom
Conversation
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Member
|
Looks like a promising solution to the Void issue with AGP-8! I'm not really sure how to test it in the Okhttp3Helper .. does anyone actually use the Okhttp3Helper? |
Member
Author
|
@AndyScherzinger @tobiasKaminsky @David-Development can you please review the idea and check whether everything still works as expected? This issue does prohibit 3rd party apps using recent build tools and I'd like to get it solved. Other opinions or ideas are welcome of course. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
David-Development
approved these changes
Sep 5, 2023
# Conflicts: # lib/src/main/java/com/nextcloud/android/sso/helper/Retrofit2Helper.java
Signed-off-by: Stefan Niedermann <info@niedermann.it>
add some unit tests for EmptyResponse
tobiasKaminsky
approved these changes
Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Voiddoes no longer work with AGP 8 #541