Set proper headers in upload requests

[artonge]

Currently, when you upload a file, the last modified time is not forwarded to the server, so it becomes the current time.

See https://docs.nextcloud.com/server/latest/developer_manual/client_apis/WebDAV/basic.html#request-headers

Can we merge the destinationFile and headers params?

[skjnldsv]

@juliushaertl @icewind1991 how much of those custom headers are still relevant today?

Some old refs:

• Fix quota calculation on new dav upload endpoint nextcloud/server#6483
• [oc] Handle OC-Total-Length in new chunking nextcloud/server#7533

[juliusknorr]

• 'X-OC-Mtime': file.lastModified,
  • Should still be relevant as this is the only way a client can set the mtime
• 'OC-Chunked': true,
  • I don't think this way of chunked uploading is still used/supported, we inteded to drop this as part of nextcloud/server@5d4efb4 but was revered for other reasons
• 'OC-Total-Length': file.size
  • I'm also unsure about this one, might be no longer relevant as from the previous one but could still be used in some sanity checks in the quota checking as far as my code search goes

Maybe @icewind1991 has some more input

[juliusknorr]

Small comment, keeping OC-Total-Length doesn't hurt to have just in case but could probably also be removed separately

[juliusknorr]

Tests need some adjustment :)

[artonge]

Tests need some adjustment :)

Adapted on the API side.

[codecov]

Codecov Report

Merging #935 (5900f74) into master (f3fd109) will increase coverage by 0.20%.
Report is 3 commits behind head on master.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #935      +/-   ##
==========================================
+ Coverage   92.10%   92.30%   +0.20%     
==========================================
  Files           3        3              
  Lines          76       78       +2     
  Branches       14       14              
==========================================
+ Hits           70       72       +2     
  Misses          3        3              
  Partials        3        3              

Files	Coverage Δ
lib/utils/upload.ts	92.59% <75.00%> (+0.59%)	⬆️