2주차 - Step1 문자열 계산기 리뷰 요청드립니다.#196
Merged
young891221 merged 27 commits intonext-step:Integerousfrom Jun 23, 2019
Merged
Conversation
young891221
approved these changes
Jun 23, 2019
young891221
left a comment
young891221
left a comment
There was a problem hiding this comment.
안녕하세요, 로또를 맡게된 리뷰어 김영재입니다.
구현 잘 하셨습니다! 커밋에서 부터 꼼꼼히 노력하신 점이 보여서 좋았습니다. 👍
몇 개의 피드백을 남깁니다.
빠른 진행을 위해 다음 단계와 함께 진행 부탁드려요ㅎㅎ
| Elements elements = Elements.from(testElements); | ||
|
|
||
| //Then | ||
| assertThat(elements).isNotNull(); |
|
|
||
| private int value; | ||
|
|
||
| public Element(int value) { |
There was a problem hiding this comment.
private으로 바꿔야 from으로만 valid check를 수행하도록 제한할 수 있을거 같네요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
안녕하세요!
1단계 문자열 계산기 리뷰 요청 드립니다!
2주차 수업시간에 배운 내용들을 활용하려고 노력했는데,
테스트 코드부터 작성하는 것에 익숙하지 않아서
잘못된 점이 많을 것으로 예상됩니다!
혹시나 제가 TDD로 작성하는 과정에 문제가 있을지 궁금하여
가능한 자주 커밋을 남겼습니다.
사소한 문제라도 많이 지적해주시면 감사하겠습니다! :]