Update size of some persistent data types#962
Merged
Conversation
gonzaponte
force-pushed
the
persistent-dtypes
branch
from
8dea80a to
3a0e1b8
Compare
Member
|
The overflow protection is nice, but shouldn't there be some warning that the user has reached the overflow limit? Having a bunch of peaks/sensor numbers with the same value may not be clear enough to the end user that they reached the int 16 bit limit. |
Collaborator
Author
|
That's reasonable, yes. |
jwaiton
approved these changes
Jun 8, 2026
jwaiton
left a comment
jwaiton
left a comment
Member
There was a problem hiding this comment.
This PR increases the memory allocation for peak and nsipm from UInt8Col to UInt16Col, increasing the maximal value from 255 to 65535!
Hopefully further increases wont be an issue for a while, and if it is, the user will be warned with the overflow checker also implemented in this PR.
Great work :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the large number of reconstructed peaks, sometimes our counters surpass the maximum values for 8-bit unsigned integers. This PR promotes these counters to 16-bit uints, which should be enough in practice. Moreover, we add some overflow protection to avoid related issues that were silently going through before the update to python 3.13 (#955).