Remove SSM-managed env vars from fly.toml#11662
Merged
Merged
Conversation
These variables are now stored in AWS SSM Parameter Store under the intercode_production chamber service and are injected at runtime by chamber. Keeping them in fly.toml is redundant and means changes require a re-deploy rather than just an SSM update. Removed: AWS_REGION, ASSETS_HOST, AUTOSCALE_MIN_INSTANCES, AUTOSCALE_MAX_INSTANCES, CLOUDWATCH_LOG_GROUP, INTERCODE_CERTS_NO_WILDCARD_DOMAINS, INTERCODE_HOST, SENTRY_PROFILES_SAMPLE_RATE, SENTRY_TRACES_SAMPLE_RATE, TWILIO_SMS_NUMBER, UPLOADS_HOST Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Intercode requires DEFAULT_CURRENCY to function, so it belongs in the Terraform module alongside the other required SSM parameters rather than hardcoded in fly.toml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Now that Chamber is working correctly and pulling secrets from SSM at runtime, there's no reason to keep those same values duplicated in
fly.toml. Having them in both places means changes to those values require a re-deploy instead of just an SSM update.Removed 11 vars that are now managed via SSM:
AWS_REGION,ASSETS_HOST,AUTOSCALE_MIN_INSTANCES,AUTOSCALE_MAX_INSTANCES,CLOUDWATCH_LOG_GROUP,INTERCODE_CERTS_NO_WILDCARD_DOMAINS,INTERCODE_HOST,SENTRY_PROFILES_SAMPLE_RATE,SENTRY_TRACES_SAMPLE_RATE,TWILIO_SMS_NUMBER,UPLOADS_HOST.Kept in
fly.toml: the Chamber bootstrap vars (CHAMBER_SERVICE,CHAMBER_AWS_ROLE_ARN) and anything not yet in SSM (DEFAULT_CURRENCY,JSON_LOGGING,MALLOC_ARENA_MAX,RACK_ENV,RAILS_ENV,RAILS_GROUPS,RAILS_LOG_TO_STDOUT,RAILS_MAX_THREADS,RAILS_SERVE_STATIC_FILES,RUBY_YJIT_ENABLE,WEB_CONCURRENCY).🤖 Generated with Claude Code