Handle raw token response from Fly OIDC endpoint#11659
Merged
Merged
Conversation
The endpoint returns the JWT token as a bare string, not wrapped in
{"token":"..."} JSON. python3 was failing to parse it as JSON and
exiting non-zero. Now try JSON first; fall back to treating the whole
response as the token value.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
After #11658 fixed the socket permission issue (running as root), the next failure showed the endpoint returns the JWT as a bare string rather than
{"token":"..."}JSON. The Python one-liner was expecting a JSON object and exited non-zero.Now tries JSON-parse first; if that fails (or there's no
tokenkey), uses the response directly as the token value.🤖 Generated with Claude Code