Skip to content

Converted to Sass#26

Closed
minusfive wants to merge 1 commit into
necolas:masterfrom
minusfive:minusfive
Closed

Converted to Sass#26
minusfive wants to merge 1 commit into
necolas:masterfrom
minusfive:minusfive

Conversation

@minusfive

Copy link
Copy Markdown

I've converted the file to Sass. Used Sass comments so when compiled they go away; this was done on purpose to get a smaller, faster, more "production ready" output. Figured devs who'd use this would see the comments in Sass either way, but don't need to see them in the output.

@necolas

necolas commented Aug 11, 2011

Copy link
Copy Markdown
Owner

Thanks for taking the time to do this. There have been a couple of pull requests related to Sass versions of the file, but I'd rather not have to maintain 2 near-identical files. I'm happy to either let people Sass-ify the file themselves or have others maintain a Sass version.

Just to note: the sub, sup section in your .sass file seems to have change from the CSS used in the original, making it a bit less efficient.

@necolas necolas closed this Aug 11, 2011
@minusfive

Copy link
Copy Markdown
Author

Cool! Thanks for the heads up on the sub/sup part, I'll check it out.

I'll publish this on my own then, and try to keep track of your changes and keep it updated.

@drublic drublic mentioned this pull request Sep 23, 2013
@kevva kevva mentioned this pull request Mar 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants