make repository language stats TypeScript-only#105
Conversation
Move the OAuth success page into a TypeScript-owned module so the repo no longer tracks a standalone HTML source file, while preserving the built dist HTML artifact and the local OAuth callback response behavior. Add narrow Linguist overrides for helper JS and shell scripts instead of broad script rewrites so the GitHub language bar reflects the package''s actual source surface without expanding scope. Constraint: User requested a GitHub language-bar outcome without a broad repo rewrite Rejected: Rewrite helper JS and shell scripts into TypeScript | unnecessary scope expansion for a repo-statistics goal Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep helper-script Linguist overrides narrow; do not hide runtime source files behind broad patterns Tested: npx vitest run test/copy-oauth-success.test.ts test/oauth-server.integration.test.ts test/server.unit.test.ts Tested: npm run lint Tested: npm run typecheck Tested: npm run build Tested: npm test Not-tested: GitHub repo language API refresh on default branch before merge
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThe changes refactor OAuth success HTML handling from runtime filesystem operations to pre-compiled module exports. The HTML is converted to a string constant, imported at server startup, and the build script updated to load from the compiled module instead of copying files. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@greptileai rerun |
Summary
lib/oauth-success.tsand keep the generateddist/lib/oauth-success.htmlbuild artifactlib/auth/server.ts.gitattributesrules so helper JavaScript and shell files stop counting toward GitHub Linguist statsTesting
npm run lintnpm run buildnpm testCompliance Confirmation
Notes
npm run typecheck; GitHub Linguist should recalculate to TypeScript-only after merge/reindex.Summary by CodeRabbit
Release Notes
Refactor
Tests
Chores
Documentation