Protobuf support#352
Merged
Merged
Conversation
smolchanovsky
requested changes
Nov 21, 2021
Member
There was a problem hiding this comment.
Good job!
There is one non-obvious point that you didn't know about:
The project Nclient.Packages.Tests contains tests that are run after the release of NuGet packages. They check that all packages are published and can be installed. You need to add a test for this package there
Member
Author
|
I've fixed last mistakes. Sorry for the delay. |
smolchanovsky
approved these changes
Nov 25, 2021
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provider for protobuf protocol was added as experimental feature. Some integration tests and acceptance tests is required, I think.