Skip to content

add exception when _resolve_url gets a template but no arguments to reso... #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hellmanj merged 1 commit into from
Jan 22, 2015
Merged

add exception when _resolve_url gets a template but no arguments to reso... #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions robotpageobjects/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,9 @@ def _resolve_url(self, *args):
self.uri_vars = uri_vars
return uritemplate.expand(self.baseurl + self.uri, uri_vars)
else:
if uri_type == 'template':
raise exceptions.UriResolutionError('%s has uri template %s , but no arguments were given to resolve it' %
(pageobj_name, self.uri))
# the user wants to open the default uri
return self.baseurl + self.uri

Expand Down
8 changes: 8 additions & 0 deletions tests/test_unit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,14 @@ def test_too_many_vars_passed_to_uri_template_in_robot(self):
po._is_robot = True
po._resolve_url("pid=foo", "bar=baz")

@raises(exceptions.UriResolutionError)
def test_no_vars_passed_to_uri_template(self):
"""There is a template but no variables are possed in."""

self.set_baseurl_env(base_file=False, arbitrary_base="http://www.ncbi.nlm.nih.gov")
self.PO.uri_template = "/pubmed/{pid}"
self.PO()._resolve_url()

@raises(exceptions.UriResolutionError)
def test_wrong_var_name_in_robot(self):
self.set_baseurl_env()
Expand Down