This repository was archived by the owner on Dec 31, 2025. It is now read-only.
Remove slf4j dependency#60
Merged
Merged
Conversation
tylertreat
approved these changes
Jun 5, 2017
| logger.debug("stan: publish interrupted"); | ||
| logger.debug("Full stack trace:", e); | ||
| // Thread.currentThread().interrupt(); | ||
| // TODO: ignore for now, but re-evaluatate this |
Contributor
There was a problem hiding this comment.
Do we have a way of tracking these TODOs? GitHub issues?
petemiron
approved these changes
Jun 6, 2017
petemiron
left a comment
petemiron
left a comment
There was a problem hiding this comment.
LGTM. To Tyler's point, we need to have a strategy on the TODO Exception Handling. I think we need to throw Exceptions, but agree we can't break existing method calls and currently not worse than just logging in debug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is basic housekeeping to keep the client libraries trim - we do not need to log. Throwing exceptions (and in rare cases writing to stdout/stderr) should suffice.