Dev some changes #67
Closed
Dev some changes #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earth2016
commented
Oct 4, 2016
earth2016
commented
- Added method to get the title when the argument is numeric and optional, the title will be shown if the title is set.
- Then I added some lines to check if the operating system is windows when that happens we will use the default value. Windows operating system shows an annoying message to the user repeatedly
Updating PHPDocs for easier use in PhpStorm
Fixed a few typos
Fixes for #34
add phpdoc for IDE autoCompletion
Fixed typographical error, changed abilty to ability in README.
…is not found in the system message repeatedly
Conflicts: README.md src/Commando/Command.php src/Commando/Option.php
nategood
reviewed
Nov 9, 2016
| Aliases: `title`, `referredToAs` | ||
|
|
||
| Add a name to refer to an argument option by. Makes the help docs a little cleaner for anonymous "argument" options. | ||
| Add a name to refer to an argument option by. Makes the help docs a little cleaner for annonymous "argument" options. |
| Aliases: `expectsFile` | ||
|
|
||
| The value specified for this option must be a valid file path. When used relative paths will be converted into fully quantify file paths and globbing is also optionally supported. See the file.php example. | ||
| The value specified for this option must be a valid file path. When used relative paths will be converted into fully quatified file paths and globbing is also optionally supported. See the file.php example. |
|
|
||
| // We allow for "dynamic" anonymous arguments, so we | ||
| // add an option for any anonymous arguments that | ||
| // We allow for "dynamic" annonymous arguments, so we |
Owner
There was a problem hiding this comment.
Again, pretty sure this was spelled correctly before.
Owner
|
Tests are failing also. |
Author
|
Thanks @nategood for replying to this. I am going to close this and start another newer. |
Author
|
I have created another pull request cleaner: #95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.