Checklist
Describe the bug
There are a few duplicate asserts and out-of-order UT_Set* functions that are run after the test function has already been called.
Code snips
|
UtAssert_True(CS_AppData.HkPacket.Payload.CmdCounter == 1, "CS_AppData.HkPacket.Payload.CmdCounter == 1"); |
|
|
|
UtAssert_True(CS_AppData.HkPacket.Payload.CmdCounter == 1, "CS_AppData.HkPacket.Payload.CmdCounter == 1"); |
|
/* Execute the function being tested */ |
|
CS_RecomputeBaselineAppCmd(&CmdPacket); |
|
UT_SetDeferredRetcode(UT_KEY(CS_GetAppResTblEntryByName), 1, true); |
|
UT_SetHandlerFunction(UT_KEY(CS_GetAppResTblEntryByName), CS_APP_CMDS_TEST_CS_GetAppResTblEntryByNameHandler1, |
|
NULL); |
Expected behavior
Correct tests.
Reporter Info
Avi Weiss @thnkslprpt
Checklist
Describe the bug
There are a few duplicate asserts and out-of-order
UT_Set*functions that are run after the test function has already been called.Code snips
CS/unit-test/cs_app_cmds_tests.c
Lines 378 to 380 in f958cc0
CS/unit-test/cs_app_cmds_tests.c
Lines 490 to 494 in f958cc0
Expected behavior
Correct tests.
Reporter Info
Avi Weiss @thnkslprpt