Update HL7 v. 2.3 IN1 and IN2 repeat flags for some fields, fixes #191#192
Merged
milkshakeuk merged 3 commits intonHapiNET:masterfrom Mar 24, 2021
Merged
Conversation
added 2 commits
March 24, 2021 13:52
Due to errors in normative database for HL7 v. 2.3, IN1 and IN2 segments had incorrect repetition flags
This comment has been minimized.
This comment has been minimized.
milkshakeuk
requested changes
Mar 24, 2021
Member
milkshakeuk
left a comment
milkshakeuk
left a comment
There was a problem hiding this comment.
@afaonline thank you very much for this, could you please add a couple of unit tests to prove the new repetition changes work when parsing a message?
Unit Test Results 5 files 54 suites 8s ⏱️ Results for commit e6c34d1. |
milkshakeuk
approved these changes
Mar 24, 2021
Member
milkshakeuk
left a comment
milkshakeuk
left a comment
There was a problem hiding this comment.
@afaonline thank you for this, looks good.
milkshakeuk
added a commit
that referenced
this pull request
Apr 15, 2021
…its not a breaking change
milkshakeuk
added a commit
that referenced
this pull request
Apr 16, 2021
…its not a breaking change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to errors in normative database for HL7 v. 2.3, IN1 and IN2 segments had incorrect repetition flags