feat: race a http gateway with p2p in iroh-one's content loader#338
Merged
Conversation
Arqu
reviewed
Oct 14, 2022
Arqu
left a comment
Arqu
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, can we get the rustfmt in order and I can merge then.
fabricedesre
force-pushed
the
iroh-one-racing-gateway
branch
from
October 14, 2022 23:14
c050acd to
72ff3c7
Compare
Contributor
Author
fixed in latest push. |
This adds to iroh-one a new optional configuration item: resolver_gateway If resolver_gateway is set, the resolver will race the p2p node with fetching a raw block from the gateway. A new source is also introduced to classify blocks coming from a gateway out from those fetched from p2p or store. Hits from the gateway are considered as not cached for telemetry purposes.
fabricedesre
force-pushed
the
iroh-one-racing-gateway
branch
from
October 14, 2022 23:43
72ff3c7 to
5416108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds to iroh-one a new optional configuration item: resolver_gateway
If resolver_gateway is set, the resolver will race the p2p node with fetching a raw block from the gateway.
A new source is also introduced to classify blocks coming from a gateway out from those fetched from p2p or store. Hits from the gateway are considered as not cached for telemetry purposes.
ping @b5