Update Canary to v1.5.1#1004
Conversation
| VERSION="${VERSION:-v1.5.0}" | ||
| VERSION="${VERSION:-v1.5.1}" | ||
|
|
||
| remove_canary_images_by_name() { |
There was a problem hiding this comment.
This function is replicated twice and should not be necessary. Use the generic remove_docker_images_by_name function.
There was a problem hiding this comment.
Fixed. Removed the Canary-specific duplicate helper and switched this back to the existing remove_docker_images_by_name helper from mynode_functions.sh.
| JWT_SECRET=$(cat "$JWT_SECRET_FILE") | ||
| EOF | ||
|
|
||
| if service_is_enabled mempool; then |
There was a problem hiding this comment.
This should be fine, but it is possible for a service to be disabled or stopped while canary is running which may lead to undesirable behavior.
There was a problem hiding this comment.
Tightened this up. Canary now only writes the local explorer env vars when the myNode service is both enabled and active at Canary startup.
That still leaves runtime changes as startup-scoped behavior: if Mempool or BTC RPC Explorer is stopped/disabled after Canary is already running, restarting Canary refreshes the advertised explorer list. I kept it scoped this way to avoid expanding this PR into a larger dynamic service-status integration.
|
|
||
| echo "==================== UNINSTALLING APP ====================" | ||
|
|
||
| remove_canary_images_by_name() { |
There was a problem hiding this comment.
Same here - function is unnecessary
There was a problem hiding this comment.
Fixed here too. Removed the duplicate helper and switched uninstall cleanup back to remove_docker_images_by_name.
| "app_status": app_status, | ||
| "app_status_color": app_status_color, | ||
| "app": app, | ||
| "canary_username": "admin@local", |
There was a problem hiding this comment.
Did the app go to not requiring a username?
There was a problem hiding this comment.
Canary still uses the fixed self-hosted username internally (admin@local). The app’s self-hosted sign-in flow now submits that fixed username automatically, so the user only needs the generated password. That is why I removed the username from the myNode info page.
| release.sh | ||
|
|
||
| # myNode app build artifacts | ||
| rootfs/standard/usr/share/mynode_apps/*/dist/ |
There was a problem hiding this comment.
I don't like this. Apps should not be build within the mynode repo.
There was a problem hiding this comment.
Removed. I agree this should not encourage building app artifacts inside the myNode repo. I’ll keep build artifacts outside the upstream repo workflow.
2 participants
Summary
Update Canary myNode app package to v1.5.1.
Release summary
Canary v1.5.1 improves self-hosted explorer settings and local platform labels for myNode. It also fixes address-watch syncing edge cases and small self-hosted UI/build issues.
Upstream release
https://github.com/schjonhaug/canary/releases/tag/v1.5.1
Test plan
mynode-sdk build canary