usda: parse typed scalar-array values inside time samples#60
Merged
Conversation
Broadens the type-aware time-sample dispatch from PR #59 to cover scalar array types (int[], float[], token[], bool[], …) in addition to tuple types. Each per-time value whose declared type is an array and whose literal opens with `[` now routes through `parse_value`, landing in the precise `IntVec` / `FloatVec` / `TokenVec` / `BoolVec` variant rather than the type-blind metadata path's `Int64Vec` / `DoubleVec` / `StringVec` fallbacks. The lenient fallback (bare scalars and `None` authored against typed properties, as in the spec corpus's `attributes.usda`) is preserved: the dispatch only kicks in when the next token opens a literal whose shape matches the declared type. Renames `next_is_typed_tuple_value` to `next_is_typed_value` since it now covers more than tuples, and updates docs accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broadens the type-aware time-sample dispatch from PR #59 to cover scalar array types (int[], float[], token[], bool[], …) in addition to tuple types. Each per-time value whose declared type is an array and whose literal opens with
[now routes throughparse_value, landing in the preciseIntVec/FloatVec/TokenVec/BoolVecvariant rather than the type-blind metadata path'sInt64Vec/DoubleVec/StringVecfallbacks.The lenient fallback (bare scalars and
Noneauthored against typed properties, as in the spec corpus'sattributes.usda) is preserved: the dispatch only kicks in when the next token opens a literal whose shape matches the declared type.Renames
next_is_typed_tuple_valuetonext_is_typed_valuesince it now covers more than tuples, and updates docs accordingly.cc: @bresilla