Skip to content

[code-infra] Port repo to use tsgo#4963

Open
brijeshb42 wants to merge 1 commit into
mui:masterfrom
brijeshb42:tsgo
Open

[code-infra] Port repo to use tsgo#4963
brijeshb42 wants to merge 1 commit into
mui:masterfrom
brijeshb42:tsgo

Conversation

@brijeshb42
Copy link
Copy Markdown
Contributor

@brijeshb42 brijeshb42 commented Jun 3, 2026 •
edited
Loading

Typechecking down from 51-54s to 7-9s (upto 6.4x less) and minor improvement in package build time.

@brijeshb42 brijeshb42 requested a review from a team June 3, 2026 05:43
@brijeshb42 brijeshb42 added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Jun 3, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jun 3, 2026 •
edited
Loading

commit: a521577

@code-infra-dashboard
Copy link
Copy Markdown

code-infra-dashboard Bot commented Jun 3, 2026 •
edited
Loading

Bundle size

Bundle Parsed size Gzip size
@base-ui/react 0B(0.00%) 0B(0.00%)

Details of bundle changes

Performance

Total duration: 1,258.04 ms -119.13 ms(-8.7%) | Renders: 50 (+0) | Paint: 1,896.55 ms -195.11 ms(-9.3%)

Test Duration Renders
Tabs mount (200 instances) 233.30 ms ▼-61.76 ms(-20.9%) 4 (+0)

11 tests within noise — details

Check out the code infra dashboard for more information about this PR.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 3, 2026 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a521577
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6a269d4c8dd2870008382314
😎 Deploy Preview https://deploy-preview-4963--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

flaviendelangle
flaviendelangle approved these changes Jun 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

vs

image

🤩 *

@brijeshb42 brijeshb42 force-pushed the tsgo branch 2 times, most recently from 5b03f8a to e956bf8 Compare June 3, 2026 06:35
michaldudak
michaldudak reviewed Jun 3, 2026
View reviewed changes
Comment thread package.json
"tailwindcss": "4.2.4",
"terser": "5.47.1",
"tsx": "4.21.0",
"typescript": "6.0.3",
Copy link
Copy Markdown
Member

@michaldudak michaldudak Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS API Extractor requires typescript as a peer dependency. If it's the only package that does so, I can declare typescript as a dev dependency there. Do you know if any other scripts use typescript@6?

Copy link
Copy Markdown
Contributor Author

@brijeshb42 brijeshb42 Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other script/package uses ts@6 yet directly AFAIK. code-infra requires a peer dep on v5.

Copy link
Copy Markdown
Member

@michaldudak michaldudak Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, I'll make it a direct dependency, then.

Copy link
Copy Markdown
Contributor Author

@brijeshb42 brijeshb42 Jun 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaldudak Ok to merge?

@brijeshb42 brijeshb42 force-pushed the tsgo branch 4 times, most recently from e6fe080 to 3617d73 Compare June 8, 2026 10:06
@brijeshb42 brijeshb42 force-pushed the tsgo branch 3 times, most recently from ad33f4d to a521577 Compare June 8, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaldudak michaldudak michaldudak left review comments

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@romgrk romgrk Awaiting requested review from romgrk romgrk is a code owner

@atomiks atomiks Awaiting requested review from atomiks atomiks is a code owner

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@aarongarciah aarongarciah Awaiting requested review from aarongarciah aarongarciah is a code owner

Assignees

No one assigned

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brijeshb42 @flaviendelangle @michaldudak