Skip to content

[menubar] Fix Menubar not disabling child Menus#2736

Merged
aarongarciah merged 3 commits into
mui:masterfrom
aarongarciah:fix-menubar-disabled
Sep 11, 2025
Merged

[menubar] Fix Menubar not disabling child Menus#2736
aarongarciah merged 3 commits into
mui:masterfrom
aarongarciah:fix-menubar-disabled

Conversation

@aarongarciah

@aarongarciah aarongarciah commented Sep 11, 2025

Copy link
Copy Markdown
Member

@aarongarciah aarongarciah added type: bug It doesn't behave as expected. component: menubar Changes related to the menubar component. labels Sep 11, 2025
@aarongarciah

aarongarciah commented Sep 11, 2025

Copy link
Copy Markdown
Member Author

Adding a test would be nice.

edit: Added.

@pkg-pr-new

pkg-pr-new Bot commented Sep 11, 2025

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@2736
pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@2736

commit: e7ffa92

@netlify

netlify Bot commented Sep 11, 2025

Copy link
Copy Markdown

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit e7ffa92
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68c31b540b11f800086b8fb0
😎 Deploy Preview https://deploy-preview-2736--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mui-bot

mui-bot commented Sep 11, 2025

Copy link
Copy Markdown

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react 🔺+83B(+0.02%) 🔺+36B(+0.03%)

Details of bundle changes

Comment thread packages/react/src/menubar/Menubar.test.tsx
Comment thread packages/react/src/menubar/Menubar.test.tsx

@michaldudak michaldudak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@aarongarciah aarongarciah merged commit bc9b221 into mui:master Sep 11, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: menubar Changes related to the menubar component. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[menubar] Menubar disabled prop does not disable menus

4 participants