Add remaining PRD build properties in Directory.Build.props#38
Merged
mpaulosky merged 2 commits intoApr 19, 2026
Merged
Conversation
4 tasks
Agent-Logs-Url: https://github.com/mpaulosky/MyBlog/sessions/3e53810d-64d0-4a05-9e5e-756edd5a93ec Co-authored-by: mpaulosky <60372079+mpaulosky@users.noreply.github.com>
6 tasks
Copilot
AI
changed the title
[WIP] Update Directory.Build.props with PRD-required build properties
Add remaining PRD build properties in Directory.Build.props
Apr 19, 2026
mpaulosky
approved these changes
Apr 19, 2026
mpaulosky
marked this pull request as ready for review
April 19, 2026 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates shared build configuration to complete the PRD-required
Directory.Build.propssettings while keeping the change scoped to one file.LangVersion,EnforceCodeStyleInBuild,EnableNETAnalyzers,AnalysisModeTreatWarningsAsErrors,ManagePackageVersionsCentrallyCodeAnalysisTreatWarningsAsErrors=falseso analyzers are enabled (AnalysisMode=All) without forcing a repo-wide analyzer cleanup in this infra-only change..csprojproperty overrides were introduced or modified.Type of Change
Domain Affected
Self-Review Checklist
Code Quality
dotnet build MyBlog.slnx --configuration Release— 0 errors, 0 warningsdotnet test MyBlog.slnx --configuration Release --no-build— all passArchitecture
Command/Query/Handler/Validatornaming conventionssealedWeborPersistence.*projectsResult<T>/ResultErrorCodeused for expected failures (no exception-driven control flow)Domain.DTOs; Models are inDomain.ModelsTests
[Collection("XxxIntegration")])IssueDto.Empty/CommentDto.Emptyinstances directlySecurity (check if security-relevant)
RequireAuthorization/ policy appliedMarkupStringused with user-supplied contentMerge Readiness
main(no merge conflicts)Screenshots / Evidence
dotnet build MyBlog.slnx --configuration Releasepassed after this change..csprojoverrides for:LangVersion,EnforceCodeStyleInBuild,EnableNETAnalyzers,AnalysisMode,TreatWarningsAsErrors.Notes for Reviewers
LangVersion=latestto match explicit issue requirements.13) for determinism; that can be handled as a separate policy decision if desired.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
compass.mongodb.com/usr/bin/mongosh mongosh --host 127.0.0.1 --port 27017 --quiet admin(dns block)/usr/bin/mongosh mongosh --host 127.0.0.1 --port 27017 --quiet admin -j DROP(dns block)If you need me to access, download, or install something from one of these locations, you can either: