fix(process): align worktree pre-push gate with required tests by mpaulosky · Pull Request #303 · mpaulosky/MyBlog

mpaulosky · 2026-05-11T20:17:53Z

Closes #299

Working as Boromir (DevOps)

Summary

Reconciles the pre-push gate enforcement with the actual test projects in the repo.
All four source-of-truth files are now consistent with each other and with ls tests/.

Changes

`.github/hooks/pre-push`

Added tests/AppHost.Tests/AppHost.Tests.csproj to Gate 5 INTEGRATION_PROJECTS

`scripts/install-hooks.sh`

Gate 4 banner now lists the real 4 unit/arch/bUnit projects
Gate 5 banner now lists Web.Tests.Integration + AppHost.Tests
Replaced permissive --no-verify emergency line with hard prohibition notice

`.squad/playbooks/pre-push-process.md`

Fixed IssueTrackerApp.slnx → MyBlog.slnx in pre-flight step 4
Removed non-existent Persistence.MongoDb.Tests / Persistence.AzureStorage.Tests from Gate 4
Removed non-existent Persistence.*.Integration projects from Gate 5
Corrected project counts (Gate 4: 4, Gate 5: 2)
Fixed Gate 5 Docker anti-pattern (was mislabelled Gate 4)

`docs/CONTRIBUTING.md`

Rewrote gate table to reflect actual 6 gates (adds Gate 2 formatting check)
Replaced stale Unit.Tests / Integration.Tests project names with real names
Replaced permissive bypass section with explicit prohibition block matching the playbook
Fixed troubleshooting heading (Gates 3 & 4 → Gates 4 & 5)

Verification

Bootstrap flow (scripts/install-hooks.sh) output confirmed ✅
Installed hook verified to match updated source via cmp ✅
All 6 pre-push gates passed on this push:
- Gate 2: dotnet format ✅
- Gate 3: Release build ✅
- Gate 4: Architecture (16), Domain (42), Web (153), bUnit (84) — all passed ✅
- Gate 5: Web.Tests.Integration + AppHost.Tests (49 total: 48 passed, 1 skipped) ✅

…ession - Merge decision inbox into .squad/decisions.md (decisions 30-31) - Decision 30: Dark Mode Base Text Colours Must Contrast Against Dark Backgrounds (Legolas) - Decision 31: CSS Visual Regressions and Test/Visual Finding Arbitration (Aragorn) - Update Legolas history: UI regression review findings (Sprint 16 fan-out) - Update Gimli history: Blazor UI regression testing (Issue #292 coverage + visual findings) - Update Aragorn history: Issue triage (#292) and PR #295 arbitration workflow Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…und 1) - Closed duplicate issue #294, merged PR #295 with all 19 CI checks green - Sprint-stamped issues #293 and #296 with title normalization - Removed go:needs-research from #293 (sufficient context), kept for #296 (Auth investigation needed) - Decision #32: PR self-authored approval pattern and Sprint triage workflow Co-authored-by: Boromir <lead-organizer@squad.local> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Add AppHost.Tests to Gate 5 INTEGRATION_PROJECTS in .github/hooks/pre-push - Remove stale Persistence.MongoDb.Tests / Persistence.AzureStorage.Tests from Gate 4 (projects do not exist in this repo) - Remove stale Persistence.*Integration projects from Gate 5 (same reason) - Fix IssueTrackerApp.slnx -> MyBlog.slnx in pre-push-process.md pre-flight step 4 - Correct gate counts in playbook (Gate 4: 4 projects, Gate 5: 2 projects) - Fix Gate 5 Docker anti-pattern (was incorrectly labelled Gate 4) - Update install-hooks.sh banner to reflect real Gate 4/5 project sets - Replace permissive --no-verify banner text with hard prohibition notice - Update CONTRIBUTING.md gate table to match actual 6-gate hook (add Gate 2 formatting) - Fix Unit.Tests / Integration.Tests references to real project names throughout - Replace permissive --no-verify bypass section with explicit prohibition block - Fix Test Failures troubleshooting heading to Gates 4 & 5 Closes #299 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-05-11T20:18:05Z

🏗️ PR Added to Squad Triage Queue

This PR has been labeled with squad and added to the triage queue.

Next steps:

The squad Lead will review and assign to an appropriate team member
A squad:member label will be added after triage

If you know which squad member should handle this, you can add the appropriate squad:member label yourself.

mpaulosky · 2026-05-11T20:21:40Z

Closing as duplicate. Issue #299 was already resolved by PR #301 (squad/299-prepush-gate-alignment), which was squash-merged to dev. The source hook, CONTRIBUTING.md, and playbooks are already aligned.

Copilot

Pull request overview

This PR updates the repository’s local pre-push gate and its associated documentation so that the enforced gates match the actual test projects under tests/, including ensuring AppHost.Tests runs as part of the Docker-backed integration/E2E gate.

Changes:

Add tests/AppHost.Tests/AppHost.Tests.csproj to the pre-push hook’s Gate 5 integration project list.
Update hook installer banner, contributing docs, and the pre-push playbook to reflect the current 6-gate model and correct test project names/counts.
(Unrelated) Adds/updates multiple .squad/ decision/history documents that reference PR #295 / Issue #292 and include future-dated entries.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`.github/hooks/pre-push`	Adds `AppHost.Tests` to Gate 5 integration/E2E projects.
`scripts/install-hooks.sh`	Updates installer banner text to reflect real Gate 4/5 project lists and bypass messaging.
`docs/CONTRIBUTING.md`	Updates contributor-facing gate table and local test commands to match the 6-gate hook.
`.squad/playbooks/pre-push-process.md`	Updates playbook gate descriptions and project lists to match the hook.
`.squad/decisions/aragorn-pr295-merge.md`	New decision log for PR #295 (appears out of scope for this PR).
`.squad/decisions.md`	Appends decisions (27–31), including a future-dated entry.
`.squad/agents/legolas/history.md`	Adds UI/button-variant history content (appears out of scope for this PR).
`.squad/agents/gimli/history.md`	Adds button-variant coverage/history content (appears out of scope for this PR).
`.squad/agents/boromir/history.md`	Adds Issue #299 summary notes (aligned with this PR’s goal).
`.squad/agents/aragorn/history.md`	Adds PR #295 notes with a future date (appears out of scope for this PR).

+## 2026-05-11 — Issue #292 Button Variant Coverage
+
+### Task
+
+Add test coverage for the Bootstrap-like button variant work without changing production code unless a legitimate test seam required it.


+**Fixed vs theme-relative colour palette:** `.btn-primary` / `.btn-secondary` use `var(--primary-*)` theme tokens so they adapt to colour-theme switches. `.btn-warning` (amber) and `.btn-destructive` (red) use fixed Tailwind palette classes — these colours carry semantic meaning that should NOT shift when the user picks a different theme.
 **Fixed colour palette — all four variants:** All button variants use fixed Tailwind palette classes, not `var(--primary-*)` theme tokens. `.btn-primary` is green, `.btn-secondary` is blue, `.btn-warning` is amber, and `.btn-destructive` is red. None shift when the user picks a different colour theme — the palette is intentionally static to give each variant a clear, invariant semantic meaning.



+# Decision #32: PR #295 Squash Merge & Sprint 19 Triage Pattern
+
+**Date:** 2026-05-15  
+**Author:** Aragorn  
+**Stakeholders:** Boromir (work-check), Legolas (UI), Gimli (testing)  


+### 27. Button Variant Colour Palette Strategy
+
+**Date:** 2025-07  
+**Author:** Legolas (Frontend)  
+**Issue:** #292  


Boromir and others added 5 commits May 11, 2026 10:45

Merge branch 'dev' of https://github.com/mpaulosky/MyBlog into dev

0202d9c

docs(squad): boromir history update for #299 pre-push alignment

a3aaf19

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 11, 2026 20:17

github-actions Bot added the squad Squad triage inbox — Lead will assign to a member label May 11, 2026

Copilot started reviewing on behalf of mpaulosky May 11, 2026 20:18 View session

mpaulosky closed this May 11, 2026

Copilot AI reviewed May 11, 2026

View reviewed changes

mpaulosky deleted the squad/299-align-worktree-pre-push-gate branch May 11, 2026 20:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(process): align worktree pre-push gate with required tests#303

fix(process): align worktree pre-push gate with required tests#303
mpaulosky wants to merge 5 commits into
devfrom
squad/299-align-worktree-pre-push-gate

mpaulosky commented May 11, 2026

Uh oh!

github-actions Bot commented May 11, 2026

Uh oh!

mpaulosky commented May 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		Fixed vs theme-relative colour palette: `.btn-primary` / `.btn-secondary` use `var(--primary-*)` theme tokens so they adapt to colour-theme switches. `.btn-warning` (amber) and `.btn-destructive` (red) use fixed Tailwind palette classes — these colours carry semantic meaning that should NOT shift when the user picks a different theme.
		Fixed colour palette — all four variants: All button variants use fixed Tailwind palette classes, not `var(--primary-*)` theme tokens. `.btn-primary` is green, `.btn-secondary` is blue, `.btn-warning` is amber, and `.btn-destructive` is red. None shift when the user picks a different colour theme — the palette is intentionally static to give each variant a clear, invariant semantic meaning.

Conversation

mpaulosky commented May 11, 2026

Summary

Changes

.github/hooks/pre-push

scripts/install-hooks.sh

.squad/playbooks/pre-push-process.md

docs/CONTRIBUTING.md

Verification

Uh oh!

github-actions Bot commented May 11, 2026

🏗️ PR Added to Squad Triage Queue

Uh oh!

mpaulosky commented May 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`.github/hooks/pre-push`

`scripts/install-hooks.sh`

`.squad/playbooks/pre-push-process.md`

`docs/CONTRIBUTING.md`