docs(squad): merge 4 inbox decisions into decisions.md#274
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Scribe merged 7 decision inbox files from Sprint 18 release orchestration: - aragorn-apphost-tests-parallel-fix.md (xunit serialization fix) - aragorn-board-sync-theme-closeout.md (board cleanup verification) - aragorn-pr-review-262-257.md (PR #262, #257 approvals) - boromir-249-apphost-clear-hardening.md (issue #249 AC1-AC3 implementation) - boromir-cleanup-240.md (worktree cleanup) - boromir-release-pr-opened.md (PR #272 opened) - boromir-theme-cleanup.md (post-theme branch cleanup) Session artifacts created: - .squad/orchestration-log/2026-05-08T18:49:02Z-boromir.md - .squad/log/2026-05-08T18:49:02Z-release-pr272.md Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- aragorn-pr273-gate: PR #273 gate approval (SemaphoreSlim harden tests) - aragorn-release-pr272-gate: Release PR #272 Sprint 18 gate approval - gimli-248-apphost-clear-test-harness: Two-tier test strategy for #248 (Decision #24) - gimli-tdd-charter: TDD as Gimli default approach supplement (Decision #25) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
squad
Contributor
🏗️ PR Added to Squad Triage QueueThis PR has been labeled with Next steps:
|
There was a problem hiding this comment.
Pull request overview
This PR updates Squad documentation by appending four decision records into .squad/decisions.md and recording related operational/session notes in multiple agent history logs.
Changes:
- Appends new decision entries (#24, #25) plus two PR gate decision writeups (PR #273 and PR #272) to
.squad/decisions.md. - Appends a new Scribe session log entry describing a board sweep and resulting issues/PRs.
- Appends/updates agent history notes for Aragorn, Boromir, and Sam to reflect recent PR gate/release activity.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
.squad/decisions.md |
Adds decision writeups and gate decision records. |
.squad/agents/scribe/history.md |
Appends a new session log entry for the 2026-05-08 board sweep. |
.squad/agents/sam/history.md |
Appends an entry documenting Issue #266 rename work. |
.squad/agents/boromir/history.md |
Appends Sprint 18 release PR #272 notes and related items. |
.squad/agents/aragorn/history.md |
Appends gate-review notes for PR #273 and PR #272. |
Comment on lines
+2088
to
+2106
| #### Context | ||
|
|
||
| Issue #248 required automated test coverage for the `clear-myblog-data` Aspire operator command. The handler in `AppHost.cs` captures the `mongo` resource builder in a closure and calls `mongo.Resource.ConnectionStringExpression.GetValueAsync(ct)` to resolve the live MongoDB connection string. This architectural choice bypasses the `ServiceProvider` — standard DI mocks cannot intercept it. | ||
|
|
||
| #### Decision | ||
|
|
||
| Use a **two-tier test strategy**: | ||
|
|
||
| 1. **Model-level unit tests** (`MongoDbClearCommandTests`, no Docker): | ||
| Boot `DistributedApplicationTestingBuilder.CreateAsync<Projects.AppHost>()` without calling `StartAsync()`. Verify the Aspire annotation contract: command name, `IsHighlighted`, `ConfirmationMessage`, and `UpdateState` enabled/disabled by health status. | ||
| **Do NOT call `ExecuteCommand` from unit tests** — `GetValueAsync()` blocks without DCP. | ||
|
|
||
| 2. **Integration tests** (`MongoClearDataIntegrationTests`, Docker required): | ||
| Use `ClearCommandAppFixture` (IAsyncLifetime) to boot a full Aspire host via `DistributedApplicationTestingBuilder.CreateAsync` + `StartAsync`. Seed MongoDB via the Driver, invoke `ExecuteCommand` through the registered annotation, and assert post-clear database state. | ||
|
|
||
| #### Consequences | ||
|
|
||
| - Unit tests run in CI without Docker. | ||
| - Integration tests are gated by Docker availability (same gate as existing integration tests). |
Comment on lines
+2083
to
+2084
| **Status:** ✅ Proposed | ||
| **Date:** 2025 |
| ### 25. Gimli's Default Test Approach — TDD / Red-Green-Refactor | ||
|
|
||
| **Status:** ✅ Documented | ||
| **Date:** 2026-05-XX |
| #### Implementation | ||
|
|
||
| - **Charter:** Gimli's `.squad/agents/gimli/charter.md` documents TDD as the default approach with references to behavior-first principles and the `/tdd` skill suite. | ||
| - **Routing:** `.squad/routing.md` injects `.squad/skills/tdd/SKILL.md` + `.github/skills/tdd/tests.md` for every Gimli testing task. |
|
|
||
| - **Charter:** Gimli's `.squad/agents/gimli/charter.md` documents TDD as the default approach with references to behavior-first principles and the `/tdd` skill suite. | ||
| - **Routing:** `.squad/routing.md` injects `.squad/skills/tdd/SKILL.md` + `.github/skills/tdd/tests.md` for every Gimli testing task. | ||
| - **Critical Rules:** Gimli enforces the full pre-push test suite (`dotnet test tests/Unit.Tests tests/Architecture.Tests -c Release`) and coverage gate (89% line threshold) before any branch push. |
| - Tests reference command name `"clear-data"` but the actual command is `"clear-myblog-data"` | ||
| - These failures are Gimli's responsibility (issue #249) | ||
|
|
||
| ## 2026-05-xx — Issue #266: Rename `_clearMutex` to `_dbMutex` |
|
|
||
| --- | ||
|
|
||
| ### 2026-05-XX — Issue #269: Blog → README Sync workflow branch protection fix |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #274 +/- ##
=======================================
Coverage 86.57% 86.57%
=======================================
Files 44 44
Lines 1043 1043
Branches 116 116
=======================================
Hits 903 903
Misses 96 96
Partials 44 44 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges 4 pending inbox decisions into
.squad/decisions.md:Also updates agent history files for Aragorn, Boromir, Sam, and Scribe.
No source code changes. Squad docs only.
Opened by Scribe (squad automation)