ci: add Domain.Tests job to squad-test.yml for xUnit v3 CI validation (#165)#174
Merged
mpaulosky merged 1 commit intoApr 25, 2026
Merged
Conversation
…#165) Add dedicated test-domain job to validate Domain.Tests runs correctly under xUnit v3. The job mirrors the Architecture.Tests pattern: - dotnet build + dotnet test with Release config - XPlat Code Coverage (Cobertura format) - TRX logger for test result publishing - Artifact upload for post-run inspection xUnit v3 is fully compatible with dotnet test, XPlat Code Coverage, and the EnricoMi TRX publisher — no runner or tool changes required. Also wired test-domain into coverage and report job dependency chains so Domain.Tests results appear in coverage reports and the job summary. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
squad
Contributor
🏗️ PR Added to Squad Triage QueueThis PR has been labeled with Next steps:
|
There was a problem hiding this comment.
Pull request overview
Adds CI coverage for the xUnit v3 pilot by running tests/Domain.Tests in the existing squad-test GitHub Actions workflow and including its results in coverage + reporting gates.
Changes:
- Added a new
test-domainjob to build and runtests/Domain.Testswith TRX + XPlat Code Coverage (Cobertura). - Updated
coverageto depend ontest-domainso its coverage is included in report generation. - Updated
reportto includetest-domainstatus in the job summary and overall failure gate.
Comment on lines
+218
to
+229
| - name: Build Domain Tests | ||
| run: dotnet build tests/Domain.Tests --configuration Release --no-restore | ||
|
|
||
| - name: Run Domain Tests | ||
| id: domain-tests | ||
| run: | | ||
| mkdir -p test-results | ||
| if [ ! -d "tests/Domain.Tests" ]; then | ||
| echo "::notice::Domain test project not found at tests/Domain.Tests - skipping" | ||
| exit 0 | ||
| fi | ||
|
|
Comment on lines
617
to
620
| if [[ "$build_status" == "failure" || "$web_status" == "failure" || \ | ||
| "$arch_status" == "failure" || "$bunit_status" == "failure" || \ | ||
| "$arch_status" == "failure" || "$domain_status" == "failure" || \ | ||
| "$bunit_status" == "failure" || \ | ||
| "$integration_status" == "failure" || "$apphost_status" == "failure" ]]; then |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## sprint/7-xunit-v3-pilot #174 +/- ##
===========================================================
+ Coverage 72.12% 72.53% +0.41%
===========================================================
Files 43 43
Lines 721 721
Branches 112 112
===========================================================
+ Hits 520 523 +3
+ Misses 150 149 -1
+ Partials 51 49 -2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
test-domainjob tosquad-test.ymlto validate that Domain.Tests runs correctly in CI under xUnit v3. This unblocks Gimli's migration work (#163/#164) — the CI pipeline is ready before test code is written.Changes
.github/workflows/squad-test.yml— 3 targeted edits:New
test-domainjob — runstests/Domain.Testswith the same pattern as other test jobs:dotnet build+dotnet test --no-build(Release config)--collect:"XPlat Code Coverage"with Cobertura formatdomain-test-resultsartifactcoveragejob — addedtest-domaintoneedslist so Domain.Tests coverage is included in the reportreportjob — addedtest-domaintoneedslist and job summary output; addeddomain_statusto the overall failure gatexUnit v3 CI Compatibility
No runner/tool changes were required:
dotnet testXPlat Code CoverageEnricoMi/publish-unit-test-result-actioncoverlet.collector10.0.0Depends on
PR #173 (feat: add xUnit v3 packages to Directory.Packages.props) should merge first so the NuGet packages are available.
Closes #165
Working as Boromir (DevOps engineer) — CI/CD pipeline management