Skip to content

feat: migrate Domain.Tests to xUnit v3 (#163) #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpaulosky merged 2 commits into from
Apr 25, 2026
Merged

feat: migrate Domain.Tests to xUnit v3 (#163) #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
791c75d
feat: migrate Domain.Tests to xUnit v3 (#163)
Apr 25, 2026
60d97ff
Merge sprint/7-xunit-v3-pilot into squad/163-domain-tests-xunit-v3-mi…
Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/Domain.Tests/Domain.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,14 @@
<PackageReference Include="MediatR"/>
<PackageReference Include="Microsoft.NET.Test.Sdk" />
<PackageReference Include="NSubstitute"/>
<PackageReference Include="xunit"/>
<PackageReference Include="xunit.v3"/>
<PackageReference Include="xunit.runner.visualstudio"/>
Comment on lines +19 to 20

Copilot AI Apr 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration to xUnit v3 in this project is missing the <OutputType>Exe</OutputType> change required by issue #163 (and recommended by the xUnit v3 migration guide for the new test host). Add OutputType=Exe in the main <PropertyGroup> for this project so the PR meets the acceptance criteria and avoids runner/adapter surprises.

Copilot uses AI. Check for mistakes.
</ItemGroup>

<ItemGroup>
<Content Include="xunit.runner.json" CopyToOutputDirectory="PreserveNewest"/>

Copilot AI Apr 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xunit.runner.json is already included by the SDK as a None item; adding it as Content Include=... can lead to the file being present in multiple item lists and makes this project inconsistent with the existing pattern in Web.Tests.Integration (which uses <None Update=...>). Prefer updating the existing None item (or removing the default inclusion) and set CopyToOutputDirectory there.

Suggested change
<Content Include="xunit.runner.json" CopyToOutputDirectory="PreserveNewest"/>
<None Update="xunit.runner.json" CopyToOutputDirectory="PreserveNewest"/>

Copilot uses AI. Check for mistakes.
</ItemGroup>

<ItemGroup>
<Using Include="Xunit"/>
</ItemGroup>
Expand Down
8 changes: 8 additions & 0 deletions tests/Domain.Tests/xunit.runner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"$schema": "https://xunit.net/schema/current/xunit.runner.schema.json",
"methodDisplay": "method",
"methodDisplayOptions": "all",
"parallelizeAssembly": true,
"parallelizeTestCollections": true,
"diagnosticMessages": false
}
Loading