test(arch): add TDD-red CachingLayerTests for IBlogPostCacheService boundary (#113) by mpaulosky · Pull Request #116 · mpaulosky/MyBlog

mpaulosky · 2026-04-24T01:22:15Z

Closes #113

Working as Gimli (Tester)

What

Adds TDD-red architecture tests enforcing that VSA handlers in MyBlog.Web.Features must NOT directly reference IDistributedCache or IMemoryCache — they must delegate all caching to IBlogPostCacheService.

Tests are currently skipped (TDD-red) pending #110 (handler refactor). Remove the Skip attributes once #110 merges.

Changes

File	Description
`tests/Architecture.Tests/CachingLayerTests.cs`	2 skipped arch tests: `Features_Should_Not_Reference_IDistributedCache_Directly`, `Features_Should_Not_Reference_IMemoryCache_Directly`
`tests/Domain.Tests/GlobalUsings.cs`	Missing global usings file (pre-existing gap)
`tests/Domain.Tests/Domain.Tests.csproj`	Stub project — unblocks Gate 3 of pre-push hook (project was deleted in #104 but hook still references it)
`MyBlog.slnx`	Register `Domain.Tests` so Release build compiles it before `--no-build` test run

Activation

Remove the Skip attribute from both facts in CachingLayerTests.cs after #110 merges:

// Before (skipped):
[Fact(Skip = "TDD-red: pending #110 — handlers must be refactored to use IBlogPostCacheService")]

// After #110 merges:
[Fact]

Depends on [Sprint 5] Extract ICacheService abstraction and centralize cache keys #109 (IBlogPostCacheService interface — already merged on squad/109-cache-abstraction)
Will be activated by [Sprint 5] Refactor BlogPost handlers to use ICacheService #110 (handler refactor removes direct cache references from Features)

…gs (#109) - CachingLayerTests skipped until #110 (handler refactor) merges - Domain.Tests/GlobalUsings.cs was untracked Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-04-24T01:22:24Z

🏗️ PR Added to Squad Triage Queue

This PR has been labeled with squad and added to the triage queue.

Next steps:

The squad Lead will review and assign to an appropriate team member
A squad:member label will be added after triage

If you know which squad member should handle this, you can add the appropriate squad:member label yourself.

) - Add tests/Domain.Tests/Domain.Tests.csproj stub (unblocks Gate 3 of pre-push hook which references this project but it was deleted in #104) - Register Domain.Tests in MyBlog.slnx so release build includes it The CachingLayerTests (already committed) are [Fact(Skip)] TDD-red, pending Sam's #110 handler refactor that adopts IBlogPostCacheService. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Adds new architecture-test coverage intended to enforce the caching abstraction boundary in the Web “Features” layer (handlers must not depend directly on IDistributedCache/IMemoryCache, and should instead delegate caching to IBlogPostCacheService).

Changes:

Adds two (currently skipped) NetArchTest rules to detect direct dependencies on Microsoft.Extensions.Caching.Distributed and Microsoft.Extensions.Caching.Memory from MyBlog.Web.Features.
Adds a GlobalUsings.cs file under tests/Domain.Tests/.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
`tests/Architecture.Tests/CachingLayerTests.cs`	Introduces two skipped architecture tests intended to prevent direct cache dependencies in the Features layer.
`tests/Domain.Tests/GlobalUsings.cs`	Adds global usings under a `tests/Domain.Tests` folder.

Copilot · 2026-04-24T01:25:25Z

+		var result = Types.InAssembly(WebAssembly)
+				.That()
+				.ResideInNamespace("MyBlog.Web.Features")
+				.ShouldNot()
+				.HaveDependencyOnAny("Microsoft.Extensions.Caching.Memory")
+				.GetResult();


Same issue as the test above: ResideInNamespace("MyBlog.Web.Features") won’t match MyBlog.Web.Features.* sub-namespaces, so this rule won’t apply to most handlers. Use ResideInNamespaceStartingWith("MyBlog.Web.Features") (or include sub-namespaces) and consider narrowing to handler types (e.g., HaveNameEndingWith("Handler")) to align with the stated goal.

Copilot · 2026-04-24T01:25:25Z

+global using FluentAssertions;
+global using MyBlog.Domain.Entities;


This file is under tests/Domain.Tests/, but there is no Domain.Tests.csproj and MyBlog.slnx doesn’t include a Domain.Tests project, so these global usings won’t be compiled or used. Either add/restore a Domain.Tests test project and include it in the solution, or remove this folder/file to avoid orphaned, misleading code.

Copilot · 2026-04-24T01:25:25Z

+		var result = Types.InAssembly(WebAssembly)
+				.That()
+				.ResideInNamespace("MyBlog.Web.Features")
+				.ShouldNot()
+				.HaveDependencyOnAny("Microsoft.Extensions.Caching.Distributed")
+				.GetResult();


ResideInNamespace("MyBlog.Web.Features") only targets types in the exact namespace and will not include handlers under MyBlog.Web.Features.* (e.g., MyBlog.Web.Features.BlogPosts.List). Once the [Fact] is un-skipped, this test will likely pass even if handlers still depend on Microsoft.Extensions.Caching.Distributed. Consider switching to ResideInNamespaceStartingWith("MyBlog.Web.Features") (or the include-subnamespaces overload) and, if the intent is “VSA handlers”, also filter to HaveNameEndingWith("Handler") to avoid accidentally policing non-handler feature types.

github-actions · 2026-04-24T01:25:36Z

Test Results Summary

203 tests +2 201 ✅ ±0 14s ⏱️ ±0s
5 suites ±0 2 💤 +2
5 files ±0 0 ❌ ±0

Results for commit fefdee8. ± Comparison against base commit 7813f99.

♻️ This comment has been updated with latest results.

codecov · 2026-04-24T01:30:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (sprint/5-redis-caching@7409725). Learn more about missing BASE report.

Additional details and impacted files

@@                    Coverage Diff                    @@
##             sprint/5-redis-caching     #116   +/-   ##
=========================================================
  Coverage                          ?   70.38%           
=========================================================
  Files                             ?       43           
  Lines                             ?      672           
  Branches                          ?      111           
=========================================================
  Hits                              ?      473           
  Misses                            ?      147           
  Partials                          ?       52

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ad/113-arch-caching-test

Sam's #115 and #118 have merged, so handlers now use IBlogPostCacheService. Both arch tests pass green: - Features_Should_Not_Reference_IDistributedCache_Directly - Features_Should_Not_Reference_IMemoryCache_Directly Closes #113 Working as Gimli (Tester) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

test(arch): add TDD-red CachingLayerTests and Domain.Tests GlobalUsin…

2d9cd8c

…gs (#109) - CachingLayerTests skipped until #110 (handler refactor) merges - Domain.Tests/GlobalUsings.cs was untracked Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 24, 2026 01:22

github-actions Bot added the squad Squad triage inbox — Lead will assign to a member label Apr 24, 2026

Copilot started reviewing on behalf of mpaulosky April 24, 2026 01:22 View session

Copilot AI reviewed Apr 24, 2026

View reviewed changes

mpaulosky mentioned this pull request Apr 24, 2026

feat(handlers): refactor all BlogPost handlers to use IBlogPostCacheService (#110) #118

Merged

Boromir and others added 2 commits April 23, 2026 18:50

Merge remote-tracking branch 'origin/sprint/5-redis-caching' into squ…

4a3a6d9

…ad/113-arch-caching-test

mpaulosky merged commit 239da3b into sprint/5-redis-caching Apr 24, 2026
7 of 8 checks passed

mpaulosky deleted the squad/113-arch-caching-test branch April 24, 2026 01:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(arch): add TDD-red CachingLayerTests for IBlogPostCacheService boundary (#113) - #116

test(arch): add TDD-red CachingLayerTests for IBlogPostCacheService boundary (#113)#116
mpaulosky merged 4 commits into
sprint/5-redis-cachingfrom
squad/113-arch-caching-test

mpaulosky commented Apr 24, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 24, 2026

Uh oh!

Copilot AI Apr 24, 2026

Uh oh!

Copilot AI Apr 24, 2026

Uh oh!

github-actions Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		global using FluentAssertions;
		global using MyBlog.Domain.Entities;

Conversation

mpaulosky commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Changes

Activation

Related

Uh oh!

github-actions Bot commented Apr 24, 2026

🏗️ PR Added to Squad Triage Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results Summary

Uh oh!

codecov Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mpaulosky commented Apr 24, 2026 •

edited

Loading

github-actions Bot commented Apr 24, 2026 •

edited

Loading

codecov Bot commented Apr 24, 2026 •

edited

Loading