Use ternary expressions to shorten code in src/core/editor/pdf_editor.js#21459
Merged
timvandermeij merged 1 commit intoJun 16, 2026
Merged
Conversation
…r.js` This makes setting a few Dictionary entries a little bit shorter, which shouldn't hurt. (Part of this code isn't fully covered by tests, so it improves overall code coverage as well.)
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
had a problem deploying
to
code-coverage
GitHub Actions
Failure
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21459 +/- ##
==========================================
+ Coverage 89.76% 89.78% +0.01%
==========================================
Files 260 260
Lines 66066 66058 -8
==========================================
+ Hits 59304 59308 +4
+ Misses 6762 6750 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
/botio browsertest |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a37cad57bc000a6/output.txt |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b530dc9a7b225ed/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b530dc9a7b225ed/output.txt Total script time: 18.34 mins
|
Snuffleupagus
had a problem deploying
to
code-coverage
GitHub Actions
Failure
Collaborator
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a37cad57bc000a6/output.txt Total script time: 46.86 mins
Image differences available at: http://54.193.163.58:8877/a37cad57bc000a6/reftest-analyzer.html#web=eq.log |
Collaborator
Author
|
The Windows ref-test "failures" are likely caused by a Firefox version update on the bot. |
timvandermeij
approved these changes
Jun 16, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes setting a few Dictionary entries a little bit shorter, which shouldn't hurt.
(Part of this code isn't fully covered by tests, so it improves overall code coverage as well.)