Skip to content

fix:add conditions in textInputChecker. x#21124

Open
ddgotyou wants to merge 1 commit into
mozilla:masterfrom
ddgotyou:fix/password-input-prevent-fix
Open

fix:add conditions in textInputChecker. x#21124
ddgotyou wants to merge 1 commit into
mozilla:masterfrom
ddgotyou:fix/password-input-prevent-fix

Conversation

@ddgotyou

Copy link
Copy Markdown

som PASSWORD TYPE INPUTS will be prevented from DEFAULT ACTIONS(like deleting).

…om PASSWORD TYPE INPUTS will be prevented from DEFAULT ACTIONS(like deleting).
@ddgotyou

ddgotyou commented Apr 20, 2026

Copy link
Copy Markdown
Author

Dear all,
When I open a pdf page using PDF.JS,My password inputs cannot delete.
It is bothering, but I find the solution that the checker just needed to complete conditions.
I think this will help us to employ our pdf.JS more comfortably.
Looking forward to your acception.

@codecov-commenter

codecov-commenter commented Apr 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.10%. Comparing base (3ccb263) to head (732b02b).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/display/editor/tools.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21124      +/-   ##
==========================================
+ Coverage   64.06%   64.10%   +0.03%     
==========================================
  Files         177      177              
  Lines      124953   124953              
==========================================
+ Hits        80051    80095      +44     
+ Misses      44902    44858      -44     
Flag Coverage Δ
fonttest 8.13% <ø> (?)
unittestcli 64.07% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

if (el instanceof HTMLInputElement) {
const { type } = el;
return type !== "text" && type !== "number";
return type !== "text" && type !== "number" && type !== "password";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have a list of the non-textinput types (button, checkbox, ...).
I don't think we've an integration test for that. Can you write one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants