Skip to content

Logging fixes for cli-support.#7332

Open
mhammond wants to merge 1 commit intomozilla:mainfrom
mhammond:push-sxtukqqqqlvn
Open

Logging fixes for cli-support.#7332
mhammond wants to merge 1 commit intomozilla:mainfrom
mhammond:push-sxtukqqqqlvn

Conversation

@mhammond
Copy link
Copy Markdown
Member

Not sure how I missed this, but logging directly with the log crate means we aren't seeing those logs.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Not sure how I missed this, but logging directly with the `log` crate
means we aren't seeing those logs.
@mhammond mhammond requested a review from bendk April 21, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants