Move layouts to the style.css#41
Closed
grappler wants to merge 1 commit into
Closed
Conversation
Open
Owner
|
I understand the thinking here but it's not something I want to do. I very specifically built the theme to separate out layouts in their respective stylesheets to a) reduce the overall length of the main stylesheet, b) allow for future layouts to be added without having to touch the main stylesheet, and c) make it easier for theme and child theme authors to understand what's going on. |
Contributor
Author
|
I don't necessarily agree but I have no problem with closing this PR. 😄 |
Owner
|
I'm considering making it a discrete fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought my solution for the multiple stylesheets was not good so this PR is to move the layout styles all to the style.css so that only one file is loaded. The layout styles is prefixed with the respective style class which is defined in the body class.