test: move moq-cli's TS verbatim coverage into moq-mux#1879
Conversation
moq-cli's publish.rs test embedded a sibling crate's fixture via include_bytes!("../../moq-mux/src/container/ts/test_data/bbb.ts"). crane's cleanCargoSource drops non-Rust files from the nix build sandbox, so the fixture went missing and `nix build .#moq-cli` failed to compile the test, turning the moq-dev/smoke nix channel red.
The test was almost entirely redundant with moq-mux's own coverage (export_scte35_roundtrip for section-framed verbatim, private_pes_carried_verbatim for PES capture). The one path unique to it, a PES-framed verbatim stream surviving a full export round-trip, moves to moq-mux as export_pes_verbatim_roundtrip using the in-crate fixture.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
WalkthroughThe pull request relocates the MPEG-TS verbatim payload round-trip test from 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The
moq-dev/smokeinterop CI'snixchannel has been red since ~2026-06-21:nix build .#moq-clifails to compile because moq-cli's test embedded a sibling crate's fixture across the crate boundary:crane's
cleanCargoSourcefilters non-Rust files out of the nix build sandbox, sobbb.tsgoes missing and the compile-timeinclude_bytes!fails. (The plaincargochannel passes because it has the whole monorepo on disk.)Change
The moq-cli test (
ts_verbatim_streams_round_trip_through_cli) was almost entirely redundant with moq-mux's own coverage, which lives where the fixture lives:export_scte35_roundtrip— section-framed SCTE-35, full export round-trip.private_pes_carried_verbatim— PES-framed verbatim capture (same stream_id and payload).The one path only the moq-cli test exercised, a PES-framed verbatim stream surviving a full export round-trip, moves to moq-mux as
export_pes_verbatim_roundtrip, using the in-cratetest_data/bbb.ts(no cross-crate reach). Net -110 lines.Public API
None. Both changes are to
#[cfg(test)]code; nopubitems touched, so this targetsmain.Test plan
cargo test -p moq-mux→ 250 passed (incl. the newexport_pes_verbatim_roundtrip)cargo test -p moq-cli→ compiles with--tests, 0 tests, exit 0 (nothing dangling after the removal)cargo fmt+clippyclean via the nix devshell (pinned toolchain)include_bytes!left anywhere in moq-cli, so thenix build .#moq-clicompile failure is resolved (CI's nix channel confirms end to end)(Written by Claude)
🤖 Generated with Claude Code