Skip to content

ci: add 60m timeout to the Check job#1777

Merged
kixelated merged 1 commit into
mainfrom
ci/check-timeout
Jun 18, 2026
Merged

ci: add 60m timeout to the Check job#1777
kixelated merged 1 commit into
mainfrom
ci/check-timeout

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Adds timeout-minutes: 60 to the self-hosted Check job (follow-up to #1775).

Without it, a wedged step holds the runner for GitHub's 6-hour default — the earlier vitest/workerd hang stalled ~45 min before being cancelled by hand. 60 min is comfortably above a cold first build while still failing fast on a true hang.

(Written by Claude)

Backstop a hang instead of holding the self-hosted runner for the 6-hour
default (the earlier vitest hang stalled ~45m before I cancelled it).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@kixelated kixelated enabled auto-merge (squash) June 18, 2026 01:49
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 414bc680-f8fd-43f9-94c8-f37a2d7ce4f6

📥 Commits

Reviewing files that changed from the base of the PR and between 759c943 and 88de2ff.

📒 Files selected for processing (1)
  • .github/workflows/check.yml

Walkthrough

The GitHub Actions check workflow gains a timeout-minutes: 60 field at the job level, accompanied by comments stating its role as a hang backstop for self-hosted runners. Previously, the job would fall back to GitHub Actions' default 6-hour timeout, which could leave self-hosted runners occupied indefinitely if a test wedged.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: adding a 60-minute timeout to the Check job. It is clear, specific, and directly related to the changeset.
Description check ✅ Passed The description is directly related to the changeset, explaining the motivation for adding the timeout, referencing the follow-up to #1775, and justifying the 60-minute choice based on practical experience.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch ci/check-timeout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated kixelated merged commit 8ae7302 into main Jun 18, 2026
1 check passed
@kixelated kixelated deleted the ci/check-timeout branch June 18, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant