fix(doc): ignore all localhost URLs in the dead-link check#1734
fix(doc): ignore all localhost URLs in the dead-link check#1734kixelated wants to merge 1 commit into
Conversation
PR #1732 added an autolink to http://localhost:4443/certificate.sha256 in setup/windows.md, which VitePress can't reach at build time, failing the doc build (and every PR's `just ci`). Generalize the existing localhost exemption from a single :5173 literal to a regex covering any localhost URL, so dev-example links don't break the build. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe VitePress 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR #1732 added an autolink to http://localhost:4443/certificate.sha256 in setup/windows.md, which VitePress can't reach at build time, failing the doc build (and every PR's `just ci`). Generalize the existing localhost exemption from a single :5173 literal to a regex covering any localhost URL. Folded in here so this PR is green on its own; supersedes #1734. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Folded into #1733 so that PR is green on its own. Closing this one. (Written by Claude) |
Problem
The
Checkworkflow is failing on every PR (including unrelated ones) because the VitePress doc build dies on a dead link:#1732 ("Windows support") added an autolink to
http://localhost:4443/certificate.sha256indoc/setup/windows.md. VitePress can't reach that localhost URL at build time, so the dead-link check fails. The config already exemptshttp://localhost:5173, but not:4443.Fix
Generalize the existing localhost exemption from a single literal to a regex matching any localhost URL (any port/path), so development-example links don't break the build going forward:
Validation
cd doc && bun run build(vianix develop) now completes (✓ building,✓ rendering pages) with no dead-link error. Biome clean.This unblocks CI for all open PRs.
(Written by Claude)
🤖 Generated with Claude Code