refactor(moq-cli): remove the capture feature#1728
Conversation
Drop the `capture` publish subcommand and its feature flag from moq-cli. A better device-capture implementation is in progress on `dev`, so this removes the existing surface to avoid carrying two implementations. - Remove the `capture` feature and the optional `moq-audio`/`moq-video` dependencies from moq-cli. - Remove the `Capture` PublishFormat variant, `CaptureArgs`, and the capture branch in `Publish::run`. The single-variant `Source` enum now collapses into `PublishDecoder` directly. - Update doc/bin/cli.md and rs/moq-video/README.md to drop references to the removed subcommand. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 3 minutes and 49 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Removes the
capturepublish subcommand and itscapturefeature flag frommoq-cli. A better device-capture implementation is in progress ondev, so this clears out the existing surface to avoid carrying two implementations.What changed
rs/moq-cli/Cargo.toml: removed thecapturefeature and the now-unused optionalmoq-audio/moq-videodependencies.rs/moq-cli/src/publish.rs: removed theCapture(CaptureArgs)PublishFormatvariant, theCaptureArgsstruct, the capture branch inPublish::run, and theimpl CaptureArgshelpers. TheSourceenum only wrappedPublishDecoderonce capture was gone, soPublish::sourceis now aPublishDecoderdirectly.doc/bin/cli.md: rewrote the "Capture a Webcam" section to drop the removed subcommand, keeping the FFmpeg-pipe approach.rs/moq-video/README.md: dropped the stale "Used bymoq-cli'scapturesubcommand" line.Notes for reviewers
moq-video/moq-audiocrates themselves are left intact; only their usage frommoq-cliis removed.cargo build -p moq-clicompiles clean.(Written by Claude)