Skip to content

refactor(moq-cli): remove the capture feature#1728

Merged
kixelated merged 1 commit into
mainfrom
claude/adoring-mclaren-41123d
Jun 14, 2026
Merged

refactor(moq-cli): remove the capture feature#1728
kixelated merged 1 commit into
mainfrom
claude/adoring-mclaren-41123d

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

Removes the capture publish subcommand and its capture feature flag from moq-cli. A better device-capture implementation is in progress on dev, so this clears out the existing surface to avoid carrying two implementations.

What changed

  • rs/moq-cli/Cargo.toml: removed the capture feature and the now-unused optional moq-audio / moq-video dependencies.
  • rs/moq-cli/src/publish.rs: removed the Capture(CaptureArgs) PublishFormat variant, the CaptureArgs struct, the capture branch in Publish::run, and the impl CaptureArgs helpers. The Source enum only wrapped PublishDecoder once capture was gone, so Publish::source is now a PublishDecoder directly.
  • doc/bin/cli.md: rewrote the "Capture a Webcam" section to drop the removed subcommand, keeping the FFmpeg-pipe approach.
  • rs/moq-video/README.md: dropped the stale "Used by moq-cli's capture subcommand" line.

Notes for reviewers

  • The moq-video / moq-audio crates themselves are left intact; only their usage from moq-cli is removed.
  • Historical CHANGELOG entries referencing the original capture work are left untouched.
  • cargo build -p moq-cli compiles clean.

(Written by Claude)

Drop the `capture` publish subcommand and its feature flag from moq-cli.
A better device-capture implementation is in progress on `dev`, so this
removes the existing surface to avoid carrying two implementations.

- Remove the `capture` feature and the optional `moq-audio`/`moq-video`
  dependencies from moq-cli.
- Remove the `Capture` PublishFormat variant, `CaptureArgs`, and the
  capture branch in `Publish::run`. The single-variant `Source` enum now
  collapses into `PublishDecoder` directly.
- Update doc/bin/cli.md and rs/moq-video/README.md to drop references to
  the removed subcommand.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@kixelated, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 49 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d9405573-2e92-447a-8dc1-e1877cf6a74c

📥 Commits

Reviewing files that changed from the base of the PR and between ae51aac and 67d941c.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • doc/bin/cli.md
  • rs/moq-cli/Cargo.toml
  • rs/moq-cli/src/publish.rs
  • rs/moq-video/README.md
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch claude/adoring-mclaren-41123d

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated
kixelated enabled auto-merge (squash) June 14, 2026 18:27
@kixelated
kixelated merged commit 6978aaf into main Jun 14, 2026
1 check passed
@kixelated
kixelated deleted the claude/adoring-mclaren-41123d branch June 14, 2026 18:45
This was referenced Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant