chore(moq-native): remove tokio-console instrumentation#1699
Conversation
Drops the optional `tokio-console` feature and its `console-subscriber` dependency from moq-native, along with the demo justfile recipes that wired it up (TOKIO_CONSOLE_BIND on the relay, `console` recipes on ports 6680/6681). With nothing left requiring it, also remove the `.cargo/config.toml` that set `--cfg tokio_unstable` repo-wide. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
💤 Files with no reviewable changes (4)
WalkthroughThis pull request removes tokio-console diagnostic tooling support throughout the codebase. The native crate no longer exports a 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Removes the
tokio-consoleintegration frommoq-nativeand the repo-widetokio_unstablebuild flag it required.rs/moq-native/src/log.rs— drop the#[cfg(feature = "tokio-console")]console_subscriber::spawn()layer.rs/moq-native/Cargo.toml— remove thetokio-consolefeature and theconsole-subscriberdependency..cargo/config.toml— deleted. Its only contents wererustflags = ["--cfg", "tokio_unstable"], which was only needed byconsole-subscriber.demo/relay/justfile— dropTOKIO_CONSOLE_BINDfrom thedefaultrecipe and remove theconsolerecipe (port 6680).demo/pub/justfile— remove theconsolerecipe (port 6681).Cargo.lock—console-subscriberand its transitive deps dropped.Why
The tokio-console instrumentation was unused, and dropping it lets us also remove the
tokio_unstablecfg that was applied to every crate in the workspace.Notes for reviewers
tokio-consolecargo feature is a feature-surface change, but there are no external consumers yet.tokio_unstablemeans any code relying on unstable tokio APIs would now fail to compile.cargo check -p moq-nativepasses, so nothing in-tree was using it.Test plan
cargo check -p moq-native(vianix develop) passesjust check(Written by Claude)