Skip to content

chore(moq-native): remove tokio-console instrumentation#1699

Merged
kixelated merged 1 commit into
mainfrom
claude/heuristic-goldwasser-d98b83
Jun 12, 2026
Merged

chore(moq-native): remove tokio-console instrumentation#1699
kixelated merged 1 commit into
mainfrom
claude/heuristic-goldwasser-d98b83

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

Removes the tokio-console integration from moq-native and the repo-wide tokio_unstable build flag it required.

  • rs/moq-native/src/log.rs — drop the #[cfg(feature = "tokio-console")] console_subscriber::spawn() layer.
  • rs/moq-native/Cargo.toml — remove the tokio-console feature and the console-subscriber dependency.
  • .cargo/config.toml — deleted. Its only contents were rustflags = ["--cfg", "tokio_unstable"], which was only needed by console-subscriber.
  • demo/relay/justfile — drop TOKIO_CONSOLE_BIND from the default recipe and remove the console recipe (port 6680).
  • demo/pub/justfile — remove the console recipe (port 6681).
  • Cargo.lockconsole-subscriber and its transitive deps dropped.

Why

The tokio-console instrumentation was unused, and dropping it lets us also remove the tokio_unstable cfg that was applied to every crate in the workspace.

Notes for reviewers

  • Removing the tokio-console cargo feature is a feature-surface change, but there are no external consumers yet.
  • Dropping tokio_unstable means any code relying on unstable tokio APIs would now fail to compile. cargo check -p moq-native passes, so nothing in-tree was using it.

Test plan

  • cargo check -p moq-native (via nix develop) passes
  • just check

(Written by Claude)

Drops the optional `tokio-console` feature and its `console-subscriber`
dependency from moq-native, along with the demo justfile recipes that
wired it up (TOKIO_CONSOLE_BIND on the relay, `console` recipes on ports
6680/6681). With nothing left requiring it, also remove the
`.cargo/config.toml` that set `--cfg tokio_unstable` repo-wide.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@kixelated
kixelated enabled auto-merge (squash) June 12, 2026 21:23
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 665faa2d-dac7-468c-820d-5ef0aa076ed7

📥 Commits

Reviewing files that changed from the base of the PR and between 28505fc and c79c4be.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • .cargo/config.toml
  • demo/pub/justfile
  • demo/relay/justfile
  • rs/moq-native/Cargo.toml
  • rs/moq-native/src/log.rs
💤 Files with no reviewable changes (4)
  • rs/moq-native/src/log.rs
  • .cargo/config.toml
  • demo/pub/justfile
  • rs/moq-native/Cargo.toml

Walkthrough

This pull request removes tokio-console diagnostic tooling support throughout the codebase. The native crate no longer exports a tokio-console optional feature or includes the console-subscriber dependency, and the Log::init function stops conditionally registering the console subscriber with the tracing registry. Development justfile recipes that provided tokio-console helper tasks for the relay (port 6680) and publisher (port 6681) are deleted, and the relay's default task no longer sets the TOKIO_CONSOLE_BIND environment variable.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly and accurately summarizes the main change: removing tokio-console instrumentation from the moq-native crate.
Description check ✅ Passed The pull request description is comprehensive and directly related to the changeset, detailing specific file changes, rationale, and test status.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch claude/heuristic-goldwasser-d98b83

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated
kixelated merged commit 56e14f0 into main Jun 12, 2026
1 check passed
@kixelated
kixelated deleted the claude/heuristic-goldwasser-d98b83 branch June 12, 2026 21:41
@moq-bot moq-bot Bot mentioned this pull request Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant