Skip to content

fix(hang): remove public SCTE-35 schema#1667

Merged
kixelated merged 1 commit into
moq-dev:mainfrom
arielmol:claude/remove-scte35-from-hang
Jun 9, 2026
Merged

fix(hang): remove public SCTE-35 schema#1667
kixelated merged 1 commit into
moq-dev:mainfrom
arielmol:claude/remove-scte35-from-hang

Conversation

@arielmol

@arielmol arielmol commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Tiny follow-up to #1658, as discussed with @kixelated:

  • remove the accidentally public SCTE-35 schema and types from @moq/hang
  • remove its dedicated tests and the now-unused @moq/json dev dependency
  • keep application extensions defined privately by their applications

The generic extension tests stay. #1617 will define the actual SCTE-35 section.

Test plan

  • bun test js/hang — 25 pass / 0 fail
  • bun run --cwd js/hang check (tsc) — clean
  • bunx biome check js/hang — clean
  • tsc on dependents js/publish / js/watch — clean

moq-dev#1658 added an scte35 catalog section and exported it from @moq/hang. SCTE-35
is an application concern, so it stays application-defined through the generic
catalog extension API. Remove the section, its dedicated tests, and the
now-unused @moq/json dev dependency. The generic extension fixtures stay
private to tests; the real SCTE-35 section will be defined by its application
integration rather than by hang.
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5cbd48f8-47c5-42b2-bb7d-4956ddab8fa1

📥 Commits

Reviewing files that changed from the base of the PR and between 9962c30 and 47a643a.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • js/hang/package.json
  • js/hang/src/catalog/index.ts
  • js/hang/src/catalog/scte35.test.ts
  • js/hang/src/catalog/scte35.ts
💤 Files with no reviewable changes (4)
  • js/hang/src/catalog/scte35.ts
  • js/hang/src/catalog/scte35.test.ts
  • js/hang/src/catalog/index.ts
  • js/hang/package.json

Walkthrough

This PR removes the scte35 catalog module from the js/hang package. The wildcard re-export of ./scte35 is deleted from the catalog barrel export in index.ts, making the module no longer part of the public API. The @moq/json workspace dependency is removed from package.json. The corresponding implementation file, tests, and schemas are also deleted but do not impact the public interface.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(hang): remove public SCTE-35 schema' clearly and concisely summarizes the main change: removing accidentally public SCTE-35 exports from the @moq/hang package.
Description check ✅ Passed The description directly relates to the changeset, explaining the rationale for removing public SCTE-35 schema/types, removing tests, and removing the unused @moq/json dependency, with a clear test plan demonstrating validation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated
kixelated merged commit afc236d into moq-dev:main Jun 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants