fix(hang): remove public SCTE-35 schema#1667
Conversation
moq-dev#1658 added an scte35 catalog section and exported it from @moq/hang. SCTE-35 is an application concern, so it stays application-defined through the generic catalog extension API. Remove the section, its dedicated tests, and the now-unused @moq/json dev dependency. The generic extension fixtures stay private to tests; the real SCTE-35 section will be defined by its application integration rather than by hang.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
💤 Files with no reviewable changes (4)
WalkthroughThis PR removes the scte35 catalog module from the js/hang package. The wildcard re-export of 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Tiny follow-up to #1658, as discussed with @kixelated:
@moq/hang@moq/jsondev dependencyThe generic extension tests stay. #1617 will define the actual SCTE-35 section.
Test plan
bun test js/hang— 25 pass / 0 failbun run --cwd js/hang check(tsc) — cleanbunx biome check js/hang— cleantscon dependentsjs/publish/js/watch— clean