relay(stats): allow multi-segment --stats-node values; move cargo-deny to ci#1489
Conversation
Treat the node suffix as a normalized path so multi-host regions can use values like `sjc/1` and `sjc/2` to nest under a shared region key without colliding on the advertised stats path. `Stats::new` now takes `Option<PathOwned>`; trailing/duplicate slashes are trimmed and an empty value after normalization collapses to None so downstream code only sees one "no node" representation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Keep the inner-loop `just check` fast and avoid blocking mid-edit on a fresh upstream advisory. CI still gets coverage via `just rs ci`, which is what `.github/workflows/check.yml` invokes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Your plan includes 4 reviews of capacity. Refill in 2 minutes and 26 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Two small unrelated changes that came up while reviewing
--stats-node:relay(stats): treat the--stats-nodevalue as a normalized path so multi-host regions can use values likesjc/1andsjc/2to nest under a shared region key without colliding on the advertised stats path.Stats::newnow takesOption<PathOwned>; trailing/duplicate slashes are trimmed and an empty value after normalization collapses toNone. Doc comments + thelocalhost.tomlexample call out the new shape explicitly.ci(rs): movecargo deny check --show-statsfromjust rs checktojust rs ciso the inner-loop check stays fast and devs aren't blocked mid-edit by a fresh upstream advisory. CI still gets coverage because.github/workflows/check.ymlinvokesjust ci.Test plan
cargo test -p moq-net --lib stats::— 17 tests pass, including newadvertised_path_multi_segment_nodeandnew_normalizes_and_drops_empty_nodecasescargo check -p moq-net -p moq-relaycargo clippy -p moq-net -p moq-relay --all-targetsjust rs checkruns clean and no longer invokescargo deny(Written by Claude)
🤖 Generated with Claude Code