Skip to content

relay(stats): allow multi-segment --stats-node values; move cargo-deny to ci#1489

Merged
kixelated merged 2 commits into
mainfrom
claude/elastic-elbakyan-2aebd5
May 24, 2026
Merged

relay(stats): allow multi-segment --stats-node values; move cargo-deny to ci#1489
kixelated merged 2 commits into
mainfrom
claude/elastic-elbakyan-2aebd5

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

Two small unrelated changes that came up while reviewing --stats-node:

  • relay(stats): treat the --stats-node value as a normalized path so multi-host regions can use values like sjc/1 and sjc/2 to nest under a shared region key without colliding on the advertised stats path. Stats::new now takes Option<PathOwned>; trailing/duplicate slashes are trimmed and an empty value after normalization collapses to None. Doc comments + the localhost.toml example call out the new shape explicitly.
  • ci(rs): move cargo deny check --show-stats from just rs check to just rs ci so the inner-loop check stays fast and devs aren't blocked mid-edit by a fresh upstream advisory. CI still gets coverage because .github/workflows/check.yml invokes just ci.

Test plan

  • cargo test -p moq-net --lib stats:: — 17 tests pass, including new advertised_path_multi_segment_node and new_normalizes_and_drops_empty_node cases
  • cargo check -p moq-net -p moq-relay
  • cargo clippy -p moq-net -p moq-relay --all-targets
  • just rs check runs clean and no longer invokes cargo deny

(Written by Claude)

🤖 Generated with Claude Code

kixelated and others added 2 commits May 24, 2026 12:49
Treat the node suffix as a normalized path so multi-host regions can
use values like `sjc/1` and `sjc/2` to nest under a shared region key
without colliding on the advertised stats path.

`Stats::new` now takes `Option<PathOwned>`; trailing/duplicate slashes
are trimmed and an empty value after normalization collapses to None
so downstream code only sees one "no node" representation.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Keep the inner-loop `just check` fast and avoid blocking mid-edit on a
fresh upstream advisory. CI still gets coverage via `just rs ci`, which
is what `.github/workflows/check.yml` invokes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@kixelated, we couldn't start this review because you've used your available PR reviews for now.

Your plan includes 4 reviews of capacity. Refill in 2 minutes and 26 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a264e7d4-a1ee-42ce-839e-49e8a7fe78c5

📥 Commits

Reviewing files that changed from the base of the PR and between 0fc1704 and 1ce31a3.

📒 Files selected for processing (4)
  • demo/relay/localhost.toml
  • rs/justfile
  • rs/moq-net/src/stats.rs
  • rs/moq-relay/src/stats.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/elastic-elbakyan-2aebd5
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch claude/elastic-elbakyan-2aebd5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated kixelated enabled auto-merge (squash) May 24, 2026 19:52
@kixelated kixelated merged commit e3f623f into main May 24, 2026
1 check passed
@kixelated kixelated deleted the claude/elastic-elbakyan-2aebd5 branch May 24, 2026 20:10
This was referenced May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant