Skip to content

Clean up CLI publish stats output#1263

Merged
kixelated merged 2 commits into
mainfrom
cli-stats-cleanup
Apr 9, 2026
Merged

Clean up CLI publish stats output#1263
kixelated merged 2 commits into
mainfrom
cli-stats-cleanup

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

  • Remove keyframes/s from stats output (not useful as a per-second metric)
  • Report bitrate in bits/s (Kbps/Mbps) instead of bytes/s (KB/s/MB/s)

Test plan

  • Run moq publish and verify output looks like: frames: 67/s bitrate: 2.1 Mbps drift: μ=7.4ms

🤖 Generated with Claude Code

- Remove keyframes/s (not useful as a per-second metric)
- Report bitrate in bits/s (Kbps/Mbps) instead of bytes/s

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9cda0784-e303-44d7-beca-31ad65b88da6

📥 Commits

Reviewing files that changed from the base of the PR and between d861622 and b281b38.

📒 Files selected for processing (1)
  • rs/moq-cli/src/publish.rs
🚧 Files skipped from review as they are similar to previous changes (1)
  • rs/moq-cli/src/publish.rs

Walkthrough

The change removes keyframes-per-second (kps) reporting and converts throughput from bytes-per-second to bitrate in bits-per-second by multiplying bytes by 8 and dividing by elapsed seconds. Display units change from B/s, KB/s, MB/s to bps, Kbps, Mbps. The status output is updated to show frames and bitrate (plus drift) instead of frames, keyframes, and bytes.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Clean up CLI publish stats output' directly and specifically describes the main change: improving the format and clarity of CLI publish statistics output.
Description check ✅ Passed The description is clearly related to the changeset, explaining the removal of keyframes/s and the switch from bytes/s to bits/s reporting in the stats output.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cli-stats-cleanup
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch cli-stats-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@kixelated kixelated enabled auto-merge (squash) April 9, 2026 19:21
@kixelated kixelated disabled auto-merge April 9, 2026 19:35
@kixelated kixelated merged commit f022a5d into main Apr 9, 2026
0 of 2 checks passed
@kixelated kixelated deleted the cli-stats-cleanup branch April 9, 2026 19:36
This was referenced Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant