feat(moq-native): support websocket-only client#1235
Conversation
Widen the cfg gates on Client::new(), connect(), and connect_inner() to also accept the `websocket` feature, so callers can compile without any QUIC backend (quinn, noq, quiche) and still connect via WebSocket. When no QUIC backend matches in connect_inner(), fall through to a direct WebSocket connection instead of bailing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe change adds the 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
cfggates onClient::new(),connect(), andconnect_inner()to accept thewebsocketfeature alone (without any QUIC backend like quinn/noq/quiche)connect_inner(), fall through to a direct WebSocket connection instead of bailingdefault-features = false, features = ["websocket", "aws-lc-rs"]for WebSocket-only transportThis is useful for debugging transport-specific issues — a customer is seeing
"dropped"disconnections from cdn.moq.dev, and we want them to test whether the issue is QUIC-specific by using WebSocket-only.Test plan
cargo check -p moq-native(default features, QUIC+WS) still compilescargo check -p moq-native --no-default-features --features websocket,aws-lc-rscompiles🤖 Generated with Claude Code