fix: pass null pointer for jemalloc prof.dump#1227
Conversation
jemalloc's prof.dump mallctl expects a NULL pointer to use the
prof_prefix path. An empty C string ("\0") is treated as an invalid
filename, causing the dump to fail with EFAULT.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe jemalloc module in the moq-relay crate updates the heap-profile dump trigger mechanism. The change modifies the second argument passed to 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
prof.dumpmallctl expects a NULL pointer to use theprof_prefixpath fromMALLOC_CONFb"\0"), which jemalloc treated as an invalid filename, causing dumps to fail withEFAULTusc.cdn.moq.dev— profiling is active butkill -USR1produces:failed to dump heap profile err=An interface with side effects failedTest plan
/tmp/moq-relay.heap.<pid>.<seq>.heap🤖 Generated with Claude Code