Fix spurious "short buffer" warnings during message decode

[kixelated]

Summary

• The non-trace decode path in both lite/message.rs and ietf/message.rs was missing a buf.remaining() < size early-return guard that existed in the trace path
• Without it, decode_msg was called with an undersized take(size) buffer, returned DecodeError::Short, and logged a warning — even though the Reader correctly handles Short by buffering more data and retrying
• Added the missing guard so Short is returned silently (as expected), matching the trace path behavior

Test plan

• cargo check -p moq-lite passes
• Verify warning spam is gone when running moq-relay with a connected client

🤖 Generated with Claude Code

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5d55b833-8006-4c5d-ad82-b293a0b344b1

📥 Commits

Reviewing files that changed from the base of the PR and between b6369d9 and 129cfb6.

📒 Files selected for processing (2)

• rs/moq-lite/src/ietf/message.rs
• rs/moq-lite/src/lite/message.rs

---

Walkthrough

The changes add bounds validation in the non-tracing code paths for message decoding across two modules. Before creating a limited buffer view with buf.take(size), the code now explicitly checks if buf.remaining() < size and returns DecodeError::Short when insufficient bytes remain. This ensures the non-tracing control flow matches the tracing-enabled path behavior.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Fix spurious "short buffer" warnings during message decode' directly and clearly summarizes the main change: adding guards to prevent spurious warnings when buffers are short but the Reader handles retries correctly.
Description check	✅ Passed	The description is related to the changeset, explaining the root cause (missing bounds check in non-trace path), the impact (spurious warnings), and the fix (adding the guard to match trace path behavior).

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch debug-short-buffer

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch debug-short-buffer

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}