Skip to content

Increase QUIC idle timeout to 30s and keep-alive to 5s#1221

Merged
kixelated merged 1 commit into
mainfrom
claude/increase-quic-keepalive-AtUmj
Apr 6, 2026
Merged

Increase QUIC idle timeout to 30s and keep-alive to 5s#1221
kixelated merged 1 commit into
mainfrom
claude/increase-quic-keepalive-AtUmj

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

The previous 10s idle timeout was too aggressive, causing premature
connection drops. Bump to 30s with a 5s keep-alive interval.

https://claude.ai/code/session_01S4vV1ymQU92mr8wkWDiuMr

The previous 10s idle timeout was too aggressive, causing premature
connection drops. Bump to 30s with a 5s keep-alive interval.

https://claude.ai/code/session_01S4vV1ymQU92mr8wkWDiuMr
@kixelated kixelated enabled auto-merge (squash) April 6, 2026 20:22
@coderabbitai

coderabbitai Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e9f759f0-d34a-49d1-8ad3-620f11aa6291

📥 Commits

Reviewing files that changed from the base of the PR and between 8954b62 and 0d9f9b9.

📒 Files selected for processing (2)
  • rs/moq-native/src/noq.rs
  • rs/moq-native/src/quinn.rs

Walkthrough

This pull request updates QUIC transport configuration parameters in two files within the MOQ-native implementation. In both rs/moq-native/src/noq.rs and rs/moq-native/src/quinn.rs, the NoqClient, NoqServer, QuinnClient, and QuinnServer constructors were modified. The max_idle_timeout parameter was increased from 10 seconds to 30 seconds, and the keep_alive_interval was adjusted from 4 seconds to 5 seconds. These are internal configuration-only modifications with no changes to exported or public APIs.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main changes: increasing QUIC idle timeout to 30s and keep-alive interval to 5s, which directly matches the modifications made to both noq.rs and quinn.rs files.
Description check ✅ Passed The description is directly related to the changeset, explaining the motivation (10s idle timeout was too aggressive) and the specific changes (30s timeout with 5s keep-alive interval) that align with the modified files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/increase-quic-keepalive-AtUmj
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch claude/increase-quic-keepalive-AtUmj

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated kixelated merged commit b6369d9 into main Apr 6, 2026
2 checks passed
@kixelated kixelated deleted the claude/increase-quic-keepalive-AtUmj branch April 6, 2026 20:45
This was referenced Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants