fix(@moq/lite): encode empty namespace as [] not [""]#1179
Merged
Conversation
`"".split("/")` in JavaScript returns `[""]`, so an empty namespace
was encoded as a 1-element tuple with an empty string instead of a
0-element tuple. Each namespace part MUST be at least one byte per spec.
Adds unit tests for namespace encoding in both Rust and TypeScript.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"".split("/")returns[""], so empty namespaces were encoded as a 1-element tuple with an empty string instead of a 0-element tuple. Each namespace part MUST be at least one byte per spec.Test plan
bun test js/lite/src/ietf/ietf.test.ts— 60 tests pass (8 new namespace tests)cargo test -p moq-lite -- ietf::namespace— 6 new tests pass[0x00](zero-length tuple), not[0x01, 0x00]🤖 Generated with Claude Code