DRIVERS-3162 Add test for SRV hostname validation when resolver and r… by aclark4life · Pull Request #1787 · mongodb/specifications

aclark4life · 2025-04-22T01:31:47Z

Driver PR:

PYTHON-5327 Add test for SRV hostname validation mongo-python-driver#2863

Please complete the following before merging:

Update changelog.
Test changes in at least one language driver.
Test these changes against all server versions and topologies (including standalone, replica set, sharded
clusters, and serverless).

ShaneHarvey · 2025-04-22T17:35:36Z


+### 5. Do not throw when return address is identical to SRV hostname and SRV hostname has three or more `.` separated parts
+
+- the SRV `mongodb+srv://blogs.mongodb.com` resolving to `blogs.mongodb.com`


Should we add the case where mongodb+srv://blogs.mongodb.com resolves to test.blogs.mongodb.com? Or is that already tested elsewhere?

Not sure. We're adding the 5th test because the previous 3 tests confirm that an error is raised. Similar to the first test in which we confirm there is no error, this test confirms there is no error. IIUC, a response of test.blogs.mongodb.com is valid because the domains match, but the hostnames are not identical so we're not looking for this particular success in this test case.

aclark4life · 2025-09-03T20:23:40Z

@dariakp @ShaneHarvey Just noticed this stalled, what's next (if you happen to recall, else I'll review!) ?

dariakp · 2025-09-15T18:17:10Z

@aclark4life The tests are pretty straightforward here and I think the only thing we were waiting on was dev prod; as Shane is the eng lead on the ticket I'll defer to his judgment on what's left to finish this spec change - you have my tentative approval modulo lint issues. It's a good idea to include a link to the driver PR/CI in the description though, for future reference.

ShaneHarvey · 2025-09-15T18:54:31Z

@aclark4life these changes LGTM but https://jira.mongodb.org/browse/DEVPROD-17419 added the real SRV hosts so we can actually add JSON spec tests for these two cases. Should we update this PR to remove the prose test and add the spec test files? JSON files are easier for drivers to implement so that would be my preference.

vector-of-bool

LGTM

sleepyStick · 2026-07-09T16:31:13Z

 - the SRV `mongodb+srv://mongo.local` resolving to `test_1.my_hostmongo.local`
 - the SRV `mongodb+srv://blogs.mongodb.com` resolving to `cluster.testmongodb.com`

+### 5. Do not throw when return address is identical to SRV hostname and SRV hostname has three or more `.` separated parts


sorry if this is silly and i'm missing something but why cant this be a unified test?

(If i'm reading the PYTHON-3527's PR correctly, I see that JSON files were added and I do believe they're in the same format as the other unified tests in this spec?)

sorry if this is silly and i'm missing something but why cant this be a unified test?

(If i'm reading the PYTHON-3527's PR correctly, I see that JSON files were added and I do believe they're in the same format as the other unified tests in this spec?)

Assume you mean PYTHON-5327! Also can you explain what that means for this PR? Add unit tests here? @blink1073 suggested something similar … also note there are two PRs for this in the driver, listed here.

Ah yes, sorry about the typo, but i was referring to the identical-hostnames-valid-four-parts.json and identical-hostnames-valid-three-parts.json‎ files specifically. I believe they're JSON spec tests and thus should be added to this repo (and are the same as the prose test you've described?)

and removed from pymongo or … ?

Good call @sleepyStick thanks!

Removed prose test case and added JSON/YAML spec test files matching the ones from the driver PR:

replica-set/identical-hostnames-valid-three-parts.{json,yml} (mongodb+srv://build.10gen.cc)

replica-set/identical-hostnames-valid-four-parts.{json,yml} (mongodb+srv://test.build.10gen.cc)

Documented two new SRV records in the DNS records table in the README (created in DEVPROD-17419 and fixed in DEVPROD-34211) so the tests are reproducible.

These can now be removed from pymongo and consumed from the spec repo like the other JSON tests. 🎉

aclark4life · 2026-07-09T17:49:06Z

@aclark4life The tests are pretty straightforward here and I think the only thing we were waiting on was dev prod; as Shane is the eng lead on the ticket I'll defer to his judgment on what's left to finish this spec change - you have my tentative approval modulo lint issues. It's a good idea to include a link to the driver PR/CI in the description though, for future reference.

@dariakp Thanks and done!

sleepyStick · 2026-07-09T18:52:06Z

A tad unrelated but it seems like the PYTHON-4575 jira ticket is actually split from DRIVERS-2922? So maybe there's only one python PR associated with this driver ticket?

…esolved hostnames are identical with three domain levels

…tests

aclark4life requested a review from a team as a code owner April 22, 2025 01:31

aclark4life requested review from dariakp and removed request for a team April 22, 2025 01:31

dariakp requested a review from ShaneHarvey April 22, 2025 13:13

ShaneHarvey reviewed Apr 22, 2025

View reviewed changes

aclark4life requested a review from ShaneHarvey April 29, 2025 13:19

vector-of-bool previously approved these changes Jul 6, 2026

View reviewed changes

aclark4life enabled auto-merge (squash) July 6, 2026 18:46

aclark4life mentioned this pull request Jul 7, 2026

PYTHON-5327 Add test for SRV hostname validation mongodb/mongo-python-driver#2863

Merged

6 tasks

Jibola disabled auto-merge July 8, 2026 20:29

dariakp requested review from a team and sleepyStick and removed request for a team and ShaneHarvey July 8, 2026 20:32

sleepyStick requested changes Jul 9, 2026

View reviewed changes

aclark4life requested a review from a team as a code owner July 9, 2026 18:46

aclark4life requested a review from qingyang-hu July 9, 2026 18:46

aclark4life requested a review from sleepyStick July 9, 2026 19:31

sleepyStick approved these changes Jul 9, 2026

View reviewed changes

blink1073 approved these changes Jul 9, 2026

View reviewed changes

qingyang-hu approved these changes Jul 9, 2026

View reviewed changes

aclark4life added 3 commits July 22, 2026 14:47

DRIVERS-3162 Add test for SRV hostname validation when resolver and r…

509c612

…esolved hostnames are identical with three domain levels

DRIVERS-3162 Use 10gen.cc hosts

8450f50

DRIVERS-3162 Convert identical-hostname prose test to JSON/YAML spec …

606b4d8

…tests

aclark4life force-pushed the DRIVERS-3162 branch from e6d53a1 to 606b4d8 Compare July 22, 2026 18:47

aclark4life dismissed vector-of-bool’s stale review via 606b4d8 July 23, 2026 16:42


		### 5. Do not throw when return address is identical to SRV hostname and SRV hostname has three or more `.` separated parts

		- the SRV `mongodb+srv://blogs.mongodb.com` resolving to `blogs.mongodb.com`

Uh oh!

Conversation

aclark4life commented Apr 22, 2025 • edited by blink1073 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShaneHarvey Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

aclark4life Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

aclark4life commented Sep 3, 2025

Uh oh!

dariakp commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShaneHarvey commented Sep 15, 2025

Uh oh!

vector-of-bool left a comment

Choose a reason for hiding this comment

Uh oh!

sleepyStick Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

aclark4life Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

sleepyStick Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aclark4life Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

aclark4life Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aclark4life commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sleepyStick commented Jul 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

aclark4life commented Apr 22, 2025 •

edited by blink1073

Loading

dariakp commented Sep 15, 2025 •

edited

Loading

sleepyStick Jul 9, 2026 •

edited

Loading

aclark4life Jul 9, 2026 •

edited

Loading

aclark4life commented Jul 9, 2026 •

edited

Loading