Skip to content

test(NODE-7656): Skip time-sensitive CSOT tests opening change streams on 9.0+ sharded clusters - #5002

Merged
tadjik1 merged 2 commits into
mainfrom
node-7656
Jul 23, 2026
Merged

test(NODE-7656): Skip time-sensitive CSOT tests opening change streams on 9.0+ sharded clusters#5002
tadjik1 merged 2 commits into
mainfrom
node-7656

Conversation

@PavelSafronov

Copy link
Copy Markdown
Contributor

Description

Summary of Changes

Skip CSOT tests against 9.0+ server.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@PavelSafronov
PavelSafronov marked this pull request as ready for review July 13, 2026 19:54
@PavelSafronov
PavelSafronov requested a review from a team as a code owner July 13, 2026 19:54
Copilot AI review requested due to automatic review settings July 13, 2026 19:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Client-Side Operations Timeout (CSOT) unified spec fixtures to skip specific change stream-opening tests on sharded clusters running MongoDB 9.0+ by tightening runOnRequirements for those test cases.

Changes:

  • Added per-test runOnRequirements to allow these change stream CSOT tests on replica sets, while restricting sharded execution to maxServerVersion: 8.99.
  • Updated both YAML and JSON representations of the affected CSOT spec suites to keep them in sync.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
test/spec/client-side-operations-timeout/retryability-timeoutMS.yml Adds topology/version gating to skip sharded 9.0+ for retryability change stream CSOT tests
test/spec/client-side-operations-timeout/retryability-timeoutMS.json Mirrors the same runOnRequirements changes in the JSON fixture consumed by the spec runner
test/spec/client-side-operations-timeout/override-operation-timeoutMS.yml Adds topology/version gating to skip sharded 9.0+ for override-timeout change stream CSOT tests
test/spec/client-side-operations-timeout/override-operation-timeoutMS.json Mirrors the same runOnRequirements changes in the JSON fixture consumed by the spec runner

Comment thread test/spec/client-side-operations-timeout/retryability-timeoutMS.yml
@tadjik1 tadjik1 self-assigned this Jul 14, 2026
@tadjik1 tadjik1 added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 14, 2026

@tadjik1 tadjik1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PavelSafronov! Please check the configuration for these tests, we already skip them.

@PavelSafronov

Copy link
Copy Markdown
Contributor Author

Thanks @PavelSafronov! Please check the configuration for these tests, we already skip them.

Excellent point. I removed the code skips and found that we need some more tests skipped in our specifications. PR opened to add these: mongodb/specifications#1964
Will update this PR after the specifications update is merged.

…ODE-7418 blanket skip

Sync the DRIVERS-3556 follow-up change-stream skips (override-collection,
override-database, retryability-legacy, and the change-streams iterate-again
case) from mongodb/specifications, update the driver's modified change-streams
spec, and remove the temporary NODE-7418 blanket >=9.0 CSOT skip so the
remaining CSOT tests run on 9.0+.

@tadjik1 tadjik1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PavelSafronov! Everything looks great!
Quick question about change streams. As far as I understood you already synced files from the open PR. Since it's the same ticket and same mechanism I don't see any problems with that, but would like to confirm is that my understanding is accurate.

@tadjik1 tadjik1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tadjik1
tadjik1 merged commit 16f6fb3 into main Jul 23, 2026
33 checks passed
@tadjik1
tadjik1 deleted the node-7656 branch July 23, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants