RUBY-3521 Add binary vector support#344
Merged
comandeo-mongo merged 12 commits intoApr 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 7 out of 11 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- spec/spec_tests/data/binary_vector/float32.json: Language not supported
- spec/spec_tests/data/binary_vector/int8.json: Language not supported
- spec/spec_tests/data/binary_vector/packed_bit.json: Language not supported
- spec/spec_tests/data/corpus/binary.json: Language not supported
Contributor
There was a problem hiding this comment.
Copilot reviewed 8 out of 12 changed files in this pull request and generated 2 comments.
Files not reviewed (4)
- spec/spec_tests/data/binary_vector/float32.json: Language not supported
- spec/spec_tests/data/binary_vector/int8.json: Language not supported
- spec/spec_tests/data/binary_vector/packed_bit.json: Language not supported
- spec/spec_tests/data/corpus/binary.json: Language not supported
Contributor
There was a problem hiding this comment.
Copilot reviewed 12 out of 16 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- spec/spec_tests/data/binary_vector/float32.json: Language not supported
- spec/spec_tests/data/binary_vector/int8.json: Language not supported
- spec/spec_tests/data/binary_vector/packed_bit.json: Language not supported
- spec/spec_tests/data/corpus/binary.json: Language not supported
Contributor
There was a problem hiding this comment.
Copilot reviewed 12 out of 16 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- spec/spec_tests/data/binary_vector/float32.json: Language not supported
- spec/spec_tests/data/binary_vector/int8.json: Language not supported
- spec/spec_tests/data/binary_vector/packed_bit.json: Language not supported
- spec/spec_tests/data/corpus/binary.json: Language not supported
Contributor
There was a problem hiding this comment.
Copilot reviewed 12 out of 16 changed files in this pull request and generated no comments.
Files not reviewed (4)
- spec/spec_tests/data/binary_vector/float32.json: Language not supported
- spec/spec_tests/data/binary_vector/int8.json: Language not supported
- spec/spec_tests/data/binary_vector/packed_bit.json: Language not supported
- spec/spec_tests/data/corpus/binary.json: Language not supported
Comments suppressed due to low confidence (1)
lib/bson/binary.rb:169
- Consider enhancing this error message by listing the supported vector types to aid debugging when an unsupported type is encountered.
raise ArgumentError, "Unsupported vector type: #{dtype_value}" unless dtype
comandeo-mongo
marked this pull request as ready for review
April 10, 2025 13:16
jamis
approved these changes
Apr 10, 2025
Comment on lines
+467
to
+468
| elsif padding.negative? || padding > 7 | ||
| raise ArgumentError, "Padding must be between 1 and 7, got #{padding}" |
Contributor
There was a problem hiding this comment.
Is padding == 0 allowed? The error message suggests not, but the condition permits it.
This was referenced Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for the new BSON::Binary subtype - binary vector
Our API differs from the spec and introduces
validate_vector_dataargument for thefrom_vectormethod. Contrary to many other languages,Array.packdoes not raise an error when supplied data does not match to the provided format. Therefore, we have to validate the input by ourselves, and this slows down the encoding significantly. So, we provide user a toggle to enable it when they need it.