Add pull request template for flint#52
Conversation
0a409fe to
fd88b54
Compare
|
Sneha, thank you for this. Can you please make sure that the contributor has to sign off? By adding their email contributors confirm that they comply with the DCO: |
Signed-off-by: Tlazypanda <itm2017004@iiita.ac.in>
fd88b54 to
eea8855
Compare
|
Hey @gmajan I have updated the pull request ✌️ |
Tlazypanda
left a comment
There was a problem hiding this comment.
Hey @gmajan Yeah the --signoff command works, there is even a shorthand for it just -s so the command will be basically like git commit -s -m "my first commit" or git commit --signoff -m "my first commit" You can find more information here https://github.com/git/git/blob/b2c150d3aa82f6583b9aadfecc5f8fa1c74aca09/Documentation/git-commit.txt#L154-L161
We can add this one too but I felt the other one might be a tad bit more convenient for developers 😅 Your call ✌️
|
Great. I am with you. Sorry for my ignorance and thank you for the link. Can we turn back the suggestion and then I will merge. |
|
@gmajan please always share your feedback, it always helps to figure out in-case I missed something out or if there is a better way to solve a problem ✌️ This is the way we will learn and grow together 🎉 |
51c4567 to
eea8855
Compare
|
@gmajan Updated pull request 🎉 |
Fixes #51 Added pull request template in
.githubfolder to ease the process of making pull requests and to follow guidelines.