Merge the pydis changes to the bot#3365
Merged
Taaku18 merged 5 commits intomodmail-dev:developmentfrom Mar 12, 2025
Merged
Conversation
Merge Development
Signed-off-by: Taku <45324516+Taaku18@users.noreply.github.com>
Update sponsors Signed-off-by: Taku <45324516+Taaku18@users.noreply.github.com>
Unescaped this was permitting any character between $ (index 36) and _ (index 95), which aren't all valid in urls.
This fixes an issue where the member may not be in the cache
Taaku18
approved these changes
Mar 12, 2025
Merged
khakers
pushed a commit
to khakers/OpenModmail
that referenced
this pull request
Apr 7, 2025
…age url search regex Merge the pydis changes to the bot (modmail-dev#3365) * Escape hyphen in regex string Unescaped this was permitting any character between $ (index 36) and _ (index 95), which aren't all valid in urls. * Get or fetch member when trying to reply This fixes an issue where the member may not be in the cache --------- Signed-off-by: Taku <45324516+Taaku18@users.noreply.github.com> Co-authored-by: Taku <45324516+Taaku18@users.noreply.github.com> Co-authored-by: Chris Lovering <chris.lovering.95@gmail.com> (cherry picked from commit 1a3bda8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The python discord has added some small patches to fix some issues with caching and the image_url regex.
This PR cherry picked those fixes and merges them to the main repo.